Bug 58829 - Clean up printStackTrace() -> proper logging
Summary: Clean up printStackTrace() -> proper logging
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.14-dev
Hardware: PC All
: P2 trivial (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks: 58822
  Show dependency tree
 
Reported: 2016-01-08 17:19 UTC by Tim Allison
Modified: 2016-01-13 16:26 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Allison 2016-01-08 17:19:24 UTC
On 58822, Jiri Banszel requested we clean up one instance of printStackTrace and convert it to logging via POILogger.

Are there any objections if I clean up the handful of other instances in actual working code?  I'll leave the printStackTraces in test and demo code.
Comment 1 Nick Burch 2016-01-13 07:49:13 UTC
Please feel free to fix this wherever you find it, including tidying up in test/demo code too if appropriate!
Comment 2 Dominik Stadler 2016-01-13 09:54:07 UTC
In r1723899 and r1723960 Andreas replaced all incorrect uses of it in the "production" code and added a forbidden-api-check which prevents newly added ones in prod-code in the future. 

Now only testcases and examples still use it in some places.
Comment 3 Dominik Stadler 2016-01-13 16:26:21 UTC
In r1724445 I removed some more occurrences, I think the remaining ones are mostly intended or test-output, thus I will set this to FIXED, feel free to fix any others that you think are not actually neccessary.