Bug 58949 - ldap code cleanup
Summary: ldap code cleanup
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-31 11:38 UTC by Felix Schumacher
Modified: 2016-01-31 14:32 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Schumacher 2016-01-31 11:38:12 UTC
Integrate the cleanup of ldap code that is suggested by https://github.com/apache/jmeter/pull/96
Comment 1 Felix Schumacher 2016-01-31 13:31:15 UTC
Date: Sun Jan 31 11:46:30 2016
New Revision: 1727793

URL: http://svn.apache.org/viewvc?rev=1727793&view=rev
Log:
Space police. Part of patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgument.java

Date: Sun Jan 31 11:48:59 2016
New Revision: 1727794

URL: http://svn.apache.org/viewvc?rev=1727794&view=rev
Log:
Space police. Part of patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArguments.java

Date: Sun Jan 31 11:54:04 2016
New Revision: 1727795

URL: http://svn.apache.org/viewvc?rev=1727795&view=rev
Log:
Space police and removal of code, that was commented out.
Part of patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java

Date: Sun Jan 31 11:56:38 2016
New Revision: 1727796

URL: http://svn.apache.org/viewvc?rev=1727796&view=rev
Log:
Narrow scope of variable.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArgumentsPanel.java

Date: Sun Jan 31 12:01:31 2016
New Revision: 1727797

URL: http://svn.apache.org/viewvc?rev=1727797&view=rev
Log:
Move constructor to the front and add javadoc.
Part of patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapConfigGui.java
Date: Sun Jan 31 12:12:49 2016
New Revision: 1727799

URL: http://svn.apache.org/viewvc?rev=1727799&view=rev
Log:
Rename method variables to start with lower case.
Remove code, that was commented out.
Space police.
Part of patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java

Date: Sun Jan 31 12:54:01 2016
New Revision: 1727806

URL: http://svn.apache.org/viewvc?rev=1727806&view=rev
Log:
Extract common code into a new method.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java

Date: Sun Jan 31 12:57:51 2016
New Revision: 1727807

URL: http://svn.apache.org/viewvc?rev=1727807&view=rev
Log:
Space police and add javadoc for constructor.
Based on patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/control/gui/LdapExtTestSamplerGui.java

Date: Sun Jan 31 13:16:48 2016
New Revision: 1727811

URL: http://svn.apache.org/viewvc?rev=1727811&view=rev
Log:
Space police and removal of parens with return and code, that was commented out.
Based on patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java
Date: Sun Jan 31 13:19:45 2016
New Revision: 1727812

URL: http://svn.apache.org/viewvc?rev=1727812&view=rev
Log:
Removal of code, that was commented out.
Based on patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapClient.java

Date: Sun Jan 31 13:23:58 2016
New Revision: 1727814

URL: http://svn.apache.org/viewvc?rev=1727814&view=rev
Log:
Move javadoc for class and combine declaration and initialisation of method variable.
Based on patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapExtClient.java


Date: Sun Jan 31 13:28:18 2016
New Revision: 1727815

URL: http://svn.apache.org/viewvc?rev=1727815&view=rev
Log:
Followup to r1727797, correct javadoc for constructor.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapConfigGui.java
Comment 2 Felix Schumacher 2016-01-31 14:32:13 UTC
Date: Sun Jan 31 14:02:05 2016
New Revision: 1727817

URL: http://svn.apache.org/viewvc?rev=1727817&view=rev
Log:
Rename private instance variable user_Defined to userDefined and increment serial version of the class.
Based on patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapConfigGui.java

Date: Sun Jan 31 14:24:04 2016
New Revision: 1727819

URL: http://svn.apache.org/viewvc?rev=1727819&view=rev
Log:
Extract common code into a new method.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapConfigGui.java


Date: Sun Jan 31 14:27:50 2016
New Revision: 1727821

URL: http://svn.apache.org/viewvc?rev=1727821&view=rev
Log:
Space police.
Part of patch by Benoit Wiart.

Bugzilla Id: 58949

Modified:
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java

Date: Sun Jan 31 14:31:40 2016
New Revision: 1727823

URL: http://svn.apache.org/viewvc?rev=1727823&view=rev
Log:
Add changes entry for the ldap changes based on a patch by Benoit Wiart.

This closes #96

Bugzilla Id: 58949

Modified:
    jmeter/trunk/xdocs/changes.xml