Bug 59064 - Remove OldSaveService which supported very old Avalon format JTL (result) files
Summary: Remove OldSaveService which supported very old Avalon format JTL (result) files
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-24 15:32 UTC by benoit.wiart
Modified: 2016-02-27 00:56 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description benoit.wiart 2016-02-24 15:32:16 UTC 
the switch to xstream was done 12 years ago..
Comment 1 Sebb 2016-02-24 19:00:45 UTC 
This will invalidate any historic test scripts that have not yet been updated to the new format.
Comment 2 Philippe Mouawad 2016-02-24 19:12:07 UTC 
Users can update their script by following:
old script => open /save in 2.13 => open in 3.0

Why maintain such old script knowing that we advise in best practices that users upgrade to recent version.
Sae thing when we get a submission of bug or question on mailing list concerning even more recent versions like 2.6.



Let's just document upgrade path and drop this class.
Comment 3 benoit.wiart 2016-02-24 20:38:50 UTC 
12 ye
Comment 4 benoit.wiart 2016-02-24 20:40:55 UTC 
12 years is plenty of time to migrate your scripts !

Maybe we should add a PunchedCardSaveService ;-)
Comment 5 Philippe Mouawad 2016-02-26 20:45:18 UTC 
(In reply to Philippe Mouawad from comment #2)
> Users can update their script by following:
> old script => open /save in 2.13 => open in 3.0
> 
> Why maintain such old script knowing that we advise in best practices that
> users upgrade to recent version.
> Sae thing when we get a submission of bug or question on mailing list
> concerning even more recent versions like 2.6.
> 
> 
> 
> Let's just document upgrade path and drop this class.

Forget about this. It is wrong
Comment 6 Philippe Mouawad 2016-02-26 20:52:03 UTC 
Author: pmouawad
Date: Fri Feb 26 20:51:17 2016
New Revision: 1732555

URL: http://svn.apache.org/viewvc?rev=1732555&view=rev
Log:
Bug 59064 - Remove OldSaveService which supported very old Avalon format JTL (result) files
Bugzilla Id: 59064

Removed:
    jmeter/trunk/src/core/org/apache/jmeter/save/OldSaveService.java
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/StatisticalSampleResult.java
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
    jmeter/trunk/xdocs/changes.xml
Comment 7 Sebb 2016-02-27 00:56:45 UTC 
(In reply to benoit.wiart from comment #4)
> 12 years is plenty of time to migrate your scripts !

However if the script still works (and as far as I know it will), why should users migrate it?

> Maybe we should add a PunchedCardSaveService ;-)

Not helpful, please don't add such comments.
Comment 8 The ASF infrastructure team 2022-09-24 20:38:02 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3854