Bug 59116 - Add the possibility to setup a prefix to sampler name recorded by proxy
Summary: Add the possibility to setup a prefix to sampler name recorded by proxy
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2016-03-04 14:38 UTC by Antonio Gomes Rodrigues
Modified: 2016-03-05 07:16 UTC (History)
2 users (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes Rodrigues 2016-03-04 14:38:18 UTC
Hi,


I have add a new option in proxy recorder to add a prefix in sampler name recorded by the proxy.

It allow to be more productive (less work to rename samplers after a recording) and complete the regex in backend listener I have add previously

Antonio
Comment 1 Antonio Gomes Rodrigues 2016-03-04 14:43:03 UTC
PR 156 commited
Comment 2 Sebb 2016-03-04 15:39:36 UTC
(In reply to Antonio Gomes Rodrigues from comment #1)
> PR 156 commited

>     https://github.com/apache/jmeter/pull/156.patch

Sorry, but the patch is unusable as it stands.

There are huge numbers of irrelevant changes which make it all but impossible to review. Here is the summary:

 .../apache/jmeter/resources/messages.properties    | 2689 ++++++++---------
 .../apache/jmeter/resources/messages_fr.properties | 2659 ++++++++---------
 .../jmeter/protocol/http/proxy/ProxyControl.java   | 3039 ++++++++++----------
 .../protocol/http/proxy/gui/ProxyControlGui.java   |   25 +-
 4 files changed, 4223 insertions(+), 4189 deletions(-)

I would expect a patch to fix this to be 100 changes or so, not 1000s.

Patches should contain the minimum number of changes.
This allows developers to quickly review the proposed change.
Also once the patch is applied, it makes the history easier to read.

If you want the patch to be applied, please provide a minimal one.
Comment 3 Antonio Gomes Rodrigues 2016-03-04 16:42:18 UTC
PR 158 without tab commited
Comment 4 Philippe Mouawad 2016-03-04 22:17:28 UTC
Thanks for PR.
I made few modification , see comments.

Author: pmouawad
Date: Fri Mar  4 22:16:39 2016
New Revision: 1733665

URL: http://svn.apache.org/viewvc?rev=1733665&view=rev
Log:
Bug 59116 - Add the possibility to setup a prefix to sampler name recorded by proxy
#resolve #158
Fixed the following in PR:
- SampleResult did not match the modified Sample label
- Added code in keyListener to ensure the model is updated, otherwise the ProxyControl would still use old prefix until user leaves the component
- French label
Bugzilla Id: 59116

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
    jmeter/trunk/xdocs/changes.xml
Comment 5 Antonio Gomes Rodrigues 2016-03-05 07:16:06 UTC
Thanks to the modifications