Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
Summary: XMLAssertion : drop jdom dependency by using XMLReader
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-09 22:18 UTC by Philippe Mouawad
Modified: 2016-03-12 20:59 UTC (History)
1 user (show)



Attachments
Patch dropping JDOM (3.12 KB, patch)
2016-03-09 22:19 UTC, Philippe Mouawad
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2016-03-09 22:18:20 UTC
Hello,
This assertion only checks that response is well-formed XML by parsing the file using JDom 1.X which is now deprecated.

I personally don't find it very useful and have never used it.
So I would tend to drop it.
If we decide to keep it, then at least we should drop jdom dependency by just using a javax SAXParser instead of:
http://www.jdom.org/docs/apidocs.1.1/org/jdom/input/SAXBuilder.html
Comment 1 Philippe Mouawad 2016-03-09 22:19:20 UTC
Created attachment 33654 [details]
Patch dropping JDOM
Comment 2 Philippe Mouawad 2016-03-12 14:27:21 UTC
Author: pmouawad
Date: Sat Mar 12 14:25:49 2016
New Revision: 1734706

URL: http://svn.apache.org/viewvc?rev=1734706&view=rev
Log:
Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
Move code to standard Java XML API
Fix Tests to remove dependencies on jdom
Move jdom download to lib/doc as it is needed for printable documentation generation (Anakia)
Remove jdom from Maven dependencies and also remove velocity version property by the way as it is not needed (commented)
Move jdom reference in build.properties in the doc block
Bugzilla Id: 59156

Modified:
    jmeter/trunk/build.properties
    jmeter/trunk/build.xml
    jmeter/trunk/eclipse.classpath
    jmeter/trunk/lib/   (props changed)
    jmeter/trunk/lib/aareadme.txt
    jmeter/trunk/lib/doc/   (props changed)
    jmeter/trunk/res/maven/ApacheJMeter_parent.pom
    jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLAssertion.java
    jmeter/trunk/test/src/org/apache/jmeter/functions/ComponentReferenceFunctionTest.java
    jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java
    jmeter/trunk/xdocs/changes.xml
Comment 3 Philippe Mouawad 2016-03-12 20:19:37 UTC
Author: pmouawad
Date: Sat Mar 12 20:18:49 2016
New Revision: 1734731

URL: http://svn.apache.org/viewvc?rev=1734731&view=rev
Log:
Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
jdom is now a jar for docs
Bugzilla Id: 59156

Modified:
    jmeter/trunk/test/src/org/apache/jmeter/JMeterVersionTest.java
Comment 4 Philippe Mouawad 2016-03-12 20:59:06 UTC
Author: pmouawad
Date: Sat Mar 12 20:58:04 2016
New Revision: 1734736

URL: http://svn.apache.org/viewvc?rev=1734736&view=rev
Log:
Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
Fix bug
Bugzilla Id: 59156

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLAssertion.java