The dialog is built dynamically from the methods in the SampleSaveConfiguration class. These may be returned in any order, and on some JVMs the order may vary. This is confusing. It would be better to generate these in a fixed order. One possible such order is alphabetical by title. This makes it easy to find entries, but will vary when changing languages. Another would be to sort by property name. That won't change with the language, but IMO does not make it quite as easy to find the entries. YMMV. However at least it's better than an unstable random order. In both cases adding a new property will generally affect the layout, as later entries will move within the 3 column dialogue.
Created attachment 33663 [details] Sample JMX with Simple Data Writer
URL: http://svn.apache.org/viewvc?rev=1734740&view=rev Log: Sample Result SaveConfig Dialog is generated in random order TODO - remove the test code when the sort order is decided Bugzilla Id: 59171 To test: jmeter -t SaveConfig.jmx [-Dsaveconfig.sort=[text|other]] If the property is omitted, no sort is done (as per now) text = order by display text other = order by property name Note: once the best order is decided, the property and redundant code can be dropped. This seemed the simplest way for devs to test the feature.
Adding tag "fix_before_3.0" so that we don't forget to remove the temp property.
(In reply to Sebb from comment #0) > The dialog is built dynamically from the methods in the > SampleSaveConfiguration class. These may be returned in any order, and on > some JVMs the order may vary. > > This is confusing. > > It would be better to generate these in a fixed order. > > One possible such order is alphabetical by title. > This makes it easy to find entries, but will vary when changing languages. > +1 for this option > Another would be to sort by property name. > That won't change with the language, but IMO does not make it quite as easy > to find the entries. YMMV. > However at least it's better than an unstable random order. > > In both cases adding a new property will generally affect the layout, as > later entries will move within the 3 column dialogue.
The order of entries is now defined by a list in SampleSaveConfiguration. This order is currently somewhat arbitrary, but agrees with a screenshot. URL: http://svn.apache.org/viewvc?rev=1735354&view=rev Log: Sample Result SaveConfig Dialog is generated in random order Bugzilla Id: 59171 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/SavePropertyDialog.java jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java jmeter/trunk/test/src/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java TODO: a better order, plus documentation updates as necessary
Updated to use documentation order (such as it is): URL: http://svn.apache.org/viewvc?rev=1735356&view=rev Log: Sample Result SaveConfig Dialog is generated in random order Use order from http://jmeter.apache.org/usermanual/listeners.html#csvlogformat Bugzilla Id: 59171 Modified: jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java
URL: http://svn.apache.org/viewvc?rev=1735467&view=rev Log: Sample Result SaveConfig Dialog is generated in random order Move knowledge of method names to the class that contains them Bugzilla Id: 59171 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/SavePropertyDialog.java jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java jmeter/trunk/test/src/org/apache/jmeter/samplers/TestSampleSaveConfiguration.java
Ok for me
Hi sebb, This bug is not in changes.xml. Should it be ? Can it know be closed ? Thanks
(In reply to Philippe Mouawad from comment #9) > Hi sebb, > This bug is not in changes.xml. > Should it be ? Yes, when it is regarded as fixed. It is a change to the behaviour of released code. > Can it know be closed ? I would like to hear from others as to whether the order is reasonable or not. Ideally we don't want to change it later, so it's worth trying to get it right now if we can. > Thanks
The order of items looks fine to me (as of https://svn.apache.org/repos/asf/jmeter/trunk@1737287).
Date: Fri Apr 15 22:26:41 2016 New Revision: 1739377 URL: http://svn.apache.org/viewvc?rev=1739377&view=rev Log: Bug 59171 - Sample Result SaveConfig Dialog is generated in random order Mention it in changes.xml Bugzilla Id: 59171 Modified: jmeter/trunk/xdocs/changes.xml
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3899