Bug 59185 - SavePropertyDialog.setSaveConfig/getSaveConfig not used; should be removed
Summary: SavePropertyDialog.setSaveConfig/getSaveConfig not used; should be removed
Status: NEW
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: PC Mac OS X 10.1
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 01:46 UTC by Sebb
Modified: 2016-03-17 01:46 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2016-03-17 01:46:18 UTC 
The SavePropertyDialog class is currently only used by AbstractVisualizer.

It seems unlikely it will be needed anywhere else, and anyway the get/set methods for the saveConfig field don't really make sense. The config is passed in via the constructor.

If the setter were dropped, the field could be made final.

Not much point having a getter either as the field is provided by the caller.
Comment 1 The ASF infrastructure team 2022-09-24 20:38:03 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3905