Bug 59240 - Introduce a slf4j adapter for Logkit
Summary: Introduce a slf4j adapter for Logkit
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-27 13:06 UTC by Philippe Mouawad
Modified: 2016-04-19 11:31 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2016-03-27 13:06:25 UTC 
Currently JMeter uses nop binder which hides sometimes interesting logs.
The idea of this bug is to introduce a static binder for Logback.
Comment 1 Philippe Mouawad 2016-03-27 13:10:50 UTC 
Author: pmouawad
Date: Sun Mar 27 13:09:58 2016
New Revision: 1736745

URL: http://svn.apache.org/viewvc?rev=1736745&view=rev
Log:
Bug 59240 - Introduce a slf4j binding for Logback
Bugzilla Id: 59240

Added:
    jmeter/trunk/src/core/org/apache/jmeter/logging/
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java   (with props)
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java   (with props)
    jmeter/trunk/src/core/org/slf4j/
    jmeter/trunk/src/core/org/slf4j/impl/
    jmeter/trunk/src/core/org/slf4j/impl/StaticLoggerBinder.java   (with props)
Modified:
    jmeter/trunk/build.xml
    jmeter/trunk/eclipse.classpath
    jmeter/trunk/lib/   (props changed)
    jmeter/trunk/lib/aareadme.txt
    jmeter/trunk/res/maven/ApacheJMeter_parent.pom
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2016-03-27 13:11:40 UTC 
Author: pmouawad
Date: Sun Mar 27 13:11:22 2016
New Revision: 1736747

URL: http://svn.apache.org/viewvc?rev=1736747&view=rev
Log:
Bug 59240 - Introduce a slf4j binding for Logback
Bugzilla Id: 59240

Modified:
    jmeter/trunk/build.properties
Comment 3 Philippe Mouawad 2016-03-27 13:26:49 UTC 
Author: pmouawad
Date: Sun Mar 27 13:24:35 2016
New Revision: 1736749

URL: http://svn.apache.org/viewvc?rev=1736749&view=rev
Log:
Bug 59240 - Introduce a slf4j binding for Logback
svn:eol
Bugzilla Id: 59240

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java   (props changed)
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java   (props changed)
    jmeter/trunk/src/core/org/slf4j/impl/StaticLoggerBinder.java   (props changed)
Comment 4 Ceki Gulcu 2016-03-27 15:21:37 UTC 
I think you mean an SLF4J adapter for logkit, not logback, which has a native implementation of slf4j-api.
Comment 5 Philippe Mouawad 2016-03-27 16:35:07 UTC 
(In reply to Ceki Gulcu from comment #4)
> I think you mean an SLF4J adapter for logkit, not logback, which has a
> native implementation of slf4j-api.

Thanks Ceki for your attention :-) 
Indeed
Comment 6 Ceki Gulcu 2016-03-27 20:28:11 UTC 
By the way, you might find the slf4j-migrator useful when migrating the logkit calls to slf4j. You would need to tweak it a little but it should be more than feasible and would save you time.
Comment 7 Sebb 2016-03-28 13:52:06 UTC 
Some of the new classes need to be renamed and the Javadocs adjusted to avoid confusing future maintainers as to the purpose of the classes.
Comment 8 Philippe Mouawad 2016-03-28 17:04:35 UTC 
Author: pmouawad
Date: Mon Mar 28 17:04:08 2016
New Revision: 1736907

URL: http://svn.apache.org/viewvc?rev=1736907&view=rev
Log:
Bug 59240 - Introduce a slf4j adapter for Logkit
Rename classes
Bugzilla Id: 59240

Added:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java   (contents, props changed)
      - copied, changed from r1736749, jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerFactory.java   (contents, props changed)
      - copied, changed from r1736749, jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java
Removed:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerAdapter.java
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogbackLoggerFactory.java
Modified:
    jmeter/trunk/src/core/org/slf4j/impl/StaticLoggerBinder.java
Comment 9 Philippe Mouawad 2016-04-19 11:31:30 UTC 
Author: pmouawad
Date: Tue Apr 19 11:30:31 2016
New Revision: 1739903

URL: http://svn.apache.org/viewvc?rev=1739903&view=rev
Log:
59240 Introduce a slf4j adapter for Logkit (this allows using slf4j within plugins and core code)
Make LogkitLoggerAdapter Serializable
Bugzilla Id: 59240

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerAdapter.java
    jmeter/trunk/src/core/org/apache/jmeter/logging/LogkitLoggerFactory.java
Comment 10 The ASF infrastructure team 2022-09-24 20:38:03 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3920