Bug 59282 - [PATCH] WebappClassLoaderBase.loadClass() throws StringIndexOutOfBoundsException
Summary: [PATCH] WebappClassLoaderBase.loadClass() throws StringIndexOutOfBoundsException
Status: RESOLVED DUPLICATE of bug 58999
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 8.0.32
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-06 18:27 UTC by Archie Cobbs
Modified: 2016-04-06 18:40 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Archie Cobbs 2016-04-06 18:27:47 UTC
This exception occurs when you attempt Class.forName("org"):

java.lang.StringIndexOutOfBoundsException: String index out of range: 3
	at java.lang.String.charAt(String.java:658) ~[?:1.8.0_72]
	at org.apache.catalina.loader.WebappClassLoaderBase.filter(WebappClassLoaderBase.java:2780) ~[catalina.jar:8.0.32]
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1253) ~[catalina.jar:8.0.32]
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1142) ~[catalina.jar:8.0.32]
	at java.lang.Class.forName0(Native Method) ~[?:1.8.0_72]
	at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_72]


This is a bug - Class.forName() should never throw StringIndexOutOfBoundsException. Instead, it should either return the class named "org" or throw a ClassNotFoundException.

Fix:

--- WebappClassLoaderBase.java.orig	2016-04-06 13:23:39.000000000 -0500
+++ WebappClassLoaderBase.java	2016-04-06 13:25:24.000000000 -0500
@@ -2751,7 +2751,7 @@
             return false;
 
         char ch;
-        if (name.startsWith("javax")) {
+        if (name.startsWith("javax") && name.length() > 5) {
             /* 5 == length("javax") */
             ch = name.charAt(5);
             if (isClassName && ch == '.') {
@@ -2775,7 +2775,7 @@
                     return true;
                 }
             }
-        } else if (name.startsWith("org")) {
+        } else if (name.startsWith("org") && name.length() > 3) {
             /* 3 == length("org") */
             ch = name.charAt(3);
             if (isClassName && ch == '.') {
Comment 1 Violeta Georgieva 2016-04-06 18:40:03 UTC
Hi,

Tomcat 8.0.33 is already available so you can switch to it.

Regards,
Violeta

*** This bug has been marked as a duplicate of bug 58999 ***