Bug 59425 - Display error in help page if the help file cannot be opened
Summary: Display error in help page if the help file cannot be opened
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.13
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-03 21:01 UTC by Sebb
Modified: 2016-05-04 20:05 UTC (History)
1 user (show)



Attachments
Display errror message in Help pane (1.56 KB, patch)
2016-05-04 19:31 UTC, Felix Schumacher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2016-05-03 21:01:20 UTC
At present if the source file for the help page cannot be opened, JMeter displays a blank page and a separate dialog box with the error. On my system the box does not get focus and may be hidden, so it's not clear what has happened.

Either the dialog should be forced to the front, or the error could be displayed on the page instead of the help text
Comment 1 Felix Schumacher 2016-05-04 19:31:31 UTC
Created attachment 33824 [details]
Display errror message in Help pane

As proposed by sebb, the error message is displayed inside the help pane and the modal dialog is removed.

Should this be added before 3.0?
Comment 2 Sebb 2016-05-04 19:44:15 UTC
I would say yes.

I don't think there is any risk in doing so.
Comment 3 Philippe Mouawad 2016-05-04 19:47:19 UTC
Ok for addition also
Comment 4 Felix Schumacher 2016-05-04 20:05:48 UTC
Date: Wed May  4 20:03:03 2016
New Revision: 1742328

URL: http://svn.apache.org/viewvc?rev=1742328&view=rev
Log:
Display error about missing help page inside the help pane

Bugzilla Id: 59425

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Help.java
    jmeter/trunk/xdocs/changes.xml