Bug 59429 - Log a message if Continue not selected and error occurs
Summary: Log a message if Continue not selected and error occurs
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: Nightly (Please specify date)
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-04 18:15 UTC by Sebb
Modified: 2016-08-12 11:00 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2016-05-04 18:15:53 UTC 
Further to Bug 59152, I think it would be useful to log a message if an error occurs and any samplers are skipped as a result. 

Even if a user has deliberately selected anything other than Continue, it can be confusing if there is no indication why some samples were not run.

This should probably be an INFO message; or possibly WARN. Not sure about that.
Comment 1 Philippe Mouawad 2016-05-04 19:38:15 UTC 
INFO level is better, because this can happen during a load test and it would flood log file.
Comment 2 Philippe Mouawad 2016-05-04 20:08:30 UTC 
@Sebb, do you intend to fix it this evening ?

Thanks
Comment 3 Philippe Mouawad 2016-08-02 20:40:12 UTC 
@sebb, a message is already logged at debug level:

 log.debug("StartNextLoop option is on, Last sample failed, starting next loop");

See:
https://github.com/apache/jmeter/blob/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java#L254

Thinking further about it, switching it to info could introduce performance regressions for test plans that have this option on (and aware of its consequence) knowing that jmeter default log level is INFO.
Comment 4 Sebb 2016-08-12 11:00:41 UTC 
If performance is an issue, then the log could be done once only