Bug 59439 - AbstractOverTimeGraphConsumer.createGroupInfos() should be abstract
Summary: AbstractOverTimeGraphConsumer.createGroupInfos() should be abstract
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.0
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-08 12:10 UTC by Sebb
Modified: 2016-09-27 08:13 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2016-05-08 12:10:02 UTC
AbstractOverTimeGraphConsumer.createGroupInfos() is in an abstract class and returns null.

Unless null is a valid value for the method (which seems unlikely), the method has to be overriden to generate a sensible result.

The implementation in the abstract class does not appear to serve any purpose and should be made abstract (or omitted, which would have the same effect).

As it stands, the implementation seems likely to cause errors as subclasses can fail to override it.
Comment 1 Philippe Mouawad 2016-09-27 08:13:24 UTC
Author: pmouawad
Date: Tue Sep 27 08:13:02 2016
New Revision: 1762407

URL: http://svn.apache.org/viewvc?rev=1762407&view=rev
Log:
Bug 59439 - AbstractOverTimeGraphConsumer.createGroupInfos() should be abstract
Bugzilla Id: 59439

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/graph/AbstractOverTimeGraphConsumer.java
    jmeter/trunk/xdocs/changes.xml