Bug 59613 - Make mod_authnz_ldap's logging/helper messages consistent after the name change
Summary: Make mod_authnz_ldap's logging/helper messages consistent after the name change
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_auth_ldap (show other bugs)
Version: 2.4.20
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
Depends on:
Reported: 2016-05-22 20:25 UTC by Tianyin Xu
Modified: 2016-05-22 20:27 UTC (History)
1 user (show)

Patch against trunk (30.13 KB, patch)
2016-05-22 20:27 UTC, Tianyin Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tianyin Xu 2016-05-22 20:25:51 UTC

Staring from 2.2 (or even earlier?), mod_auth_ldap is renamed to mod_authnz_ldap. But the logging and helper messages of mod_authnz_ldap still refer to the old name, i.e., "auth_ldap".

The following patch makes the module name consistent to the users. It only changes the logging and helper messages, rather than data structures or function names (which are not visible to the users).

The patch changes the following 4 patterns:

1. In mod_authnz_ldap, every authn/authz log is prefixed with
"auth_ldap authenticate:" or "auth_ldap authorize"
The patch changes "auth_ldap" to "authnz_ldap"

2. There are some logs use the prefix "ldap authorize" and the patch changes "ldap" to "authnz_ldap" (these has nothing to do with util_ldap.

3. In addition, it changes "auth_ldap" to "authnz_ldap" in 3 helper message for the directives in this module. 

4. In comments where the old name is used.

P.S. I examined all the log statement and helper message, so it should not introduce any inconsistencies.
Comment 1 Tianyin Xu 2016-05-22 20:27:03 UTC
Created attachment 33863 [details]
Patch against trunk