Bug 59833 - Promote FillPatternType-based getFillPattern/setFillPattern to Common SS
Summary: Promote FillPatternType-based getFillPattern/setFillPattern to Common SS
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: 3.15-dev
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks: 59836
  Show dependency tree
 
Reported: 2016-07-08 22:27 UTC by Javen O'Neal
Modified: 2016-07-10 07:01 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2016-07-08 22:27:05 UTC
FillPatternType enum was added in r701797 to XSSFCellStyle, but never added to HSSFCellStyle. In the interest of making the HSSF and XSSF share the same Common SS API and in the interest of having typed parameters, HSSFCellStyle should have the same changes.

We should favor the FillPatternType enum variants and in the future remove the non-typed methods that operate on shorts.
Comment 1 Javen O'Neal 2016-07-08 22:28:52 UTC
Applied in r1751972.