Bug 59945 - Default Groovy engine to JSR223 elements when no language is chosen in GUI
Summary: Default Groovy engine to JSR223 elements when no language is chosen in GUI
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.0
Hardware: PC Windows NT
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-04 21:08 UTC by Antonio Gomes Rodrigues
Modified: 2016-10-17 20:09 UTC (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes Rodrigues 2016-08-04 21:08:01 UTC 
Hi,

If the script language has not been chosen on the GUI, I propose to add a WARN message into the log to inform that the script will be interpreted as a groovy script

It's avoid message like "ERROR - jmeter.protocol.java.sampler.JSR223Sampler: Problem in JSR223 script Echantillon JSR223, message:javax.script.ScriptException: Cannot find engine named: '', ensure you set language field in JSR223 Test Element:Echantillon JSR223" and allow to execute the  script

Antonio
Comment 1 Antonio Gomes Rodrigues 2016-08-04 21:14:40 UTC 
PR https://github.com/apache/jmeter/pull/223 commited

Antonio
Comment 2 Philippe Mouawad 2016-10-08 08:39:35 UTC 
Author: agomes
Date: Fri Sep 23 19:28:58 2016
New Revision: 1762082

URL: http://svn.apache.org/viewvc?rev=1762082&view=rev
Log:
This closes #223

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/JSR223TestElement.java
    jmeter/trunk/src/core/org/apache/jmeter/util/ScriptingTestElement.java
    jmeter/trunk/xdocs/changes.xml
Comment 3 Philippe Mouawad 2016-10-08 08:40:09 UTC 
Author: pmouawad
Date: Sat Sep 24 08:31:07 2016
New Revision: 1762110

URL: http://svn.apache.org/viewvc?rev=1762110&view=rev
Log:
Bug 59945 For all JSR223 elements, if script language has not been chosen on the UI, the script will be interpreted as a groovy script
A getXXX method should not change state, so read every time and default (slight performance loss)
Add javadocs
Drop unused log field
Increment serialVersionId
Comment 4 Philippe Mouawad 2016-10-17 20:09:10 UTC 
Author: pmouawad
Date: Mon Oct 17 20:08:23 2016
New Revision: 1765364

URL: http://svn.apache.org/viewvc?rev=1765364&view=rev
Log:
Bug 59945 For all JSR223 elements, if script language has not been chosen on the UI, the script will be interpreted as a groovy script.
Bugzilla Id: 59945

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/ScriptingBeanInfoSupport.java
Comment 5 The ASF infrastructure team 2022-09-24 20:38:04 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4040