Bug 59948 - New formated and sane HTML source code render to View Results Tree
Summary: New formated and sane HTML source code render to View Results Tree
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.0
Hardware: PC Windows NT
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-05 13:05 UTC by Antonio Gomes Rodrigues
Modified: 2016-09-24 12:16 UTC (History)
1 user (show)


Attachments
Text render (75.51 KB, image/png)
2016-08-05 13:05 UTC, Antonio Gomes Rodrigues 		Details
HTML formated render (43.94 KB, image/png)
2016-08-05 13:06 UTC, Antonio Gomes Rodrigues 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes Rodrigues 2016-08-05 13:05:54 UTC 
Created attachment 34106 [details]
Text render

Hi,

In "View Results Tree" we can check the HTML source code with Text render.

Like you can see in HTMLNotFormated.png attached file, it could be complex to read the source code.

I propose to use Jsoup (already use in JMeter)to format/sane the HTML source code in a new render called HTML formated

The result : HTMLFormated.png

Antonio
Comment 1 Antonio Gomes Rodrigues 2016-08-05 13:06:33 UTC 
Created attachment 34107 [details]
HTML formated render
Comment 2 UbikLoadPack support 2016-08-05 13:09:48 UTC 
Hello,
It's an interesting proposal, but I would suggest to add a checkbox or button that provokes the formatting.

Because JSoup may fail to format HTML or modify/cleanup the HTML introducing a change with the original.

Thanks
Comment 3 Antonio Gomes Rodrigues 2016-08-05 13:20:38 UTC 
Yes JSoup can modify/cleanup the HTML.
It's why I don't have modify the original render (Text) to allow user to see the original response.
The new render is (in my opinion) just to understand response on errors when the response display an error (e.g. in a login page, your login/password is not good)

Can you attach a screenshot with the checkbox or button you want to add?

Because it will be interested only for Text render

Antonio
Comment 4 Sebb 2016-08-12 12:04:05 UTC 
The new formatter shows HTML Source, so I think that should be the name.
Comment 5 Antonio Gomes Rodrigues 2016-09-14 20:43:29 UTC 
Code commited in SVN
Antonio
Comment 6 Felix Schumacher 2016-09-24 12:16:43 UTC 
Date: Wed Sep 14 14:55:29 2016
New Revision: 1760716

URL: http://svn.apache.org/viewvc?rev=1760716&view=rev
Log:
This closes #224

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml

Date: Wed Sep 14 20:18:03 2016
New Revision: 1760749

URL: http://svn.apache.org/viewvc?rev=1760749&view=rev
Log:
Add RenderAsHTMLFormated.java file

Added:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsHTMLFormated.java

Date: Sat Sep 24 12:10:03 2016
New Revision: 1762119

URL: http://svn.apache.org/viewvc?rev=1762119&view=rev
Log:
Correct typo. Followup to r1760716 and r1760749.
Relates to github issue #224

Bugzilla Id: 55948