Bug 60025 - [PATCH] DataFormatter should return TRUE or FALSE for boolean cell values
Summary: [PATCH] DataFormatter should return TRUE or FALSE for boolean cell values
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: SS Common (show other bugs)
Version: 3.15-dev
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2016-08-20 05:36 UTC by Javen O'Neal
Modified: 2016-09-11 03:38 UTC (History)
0 users


Attachments
Unit test and DataFormatter fix (1.71 KB, patch)
2016-08-20 05:39 UTC, Javen O'Neal 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javen O'Neal 2016-08-20 05:36:11 UTC 
Cell cell;
cell.setCellValue(true);
DataFormatter formatter = new DataFormatter();
assertEquals("TRUE", formatter.formatCellValue(cell, null));

For HSSFWorkbook: Expected "TRUE", got "true".
Comment 1 Javen O'Neal 2016-08-20 05:39:50 UTC 
Created attachment 34165 [details]
Unit test and DataFormatter fix

From https://mail-archives.apache.org/mod_mbox/poi-user/201608.mbox/%3CCAM%2BTppKh7NJap883d%2BoWAY0SNXJL-WGO9OStEGXoRqVxSgJ%2BEQ%40mail.gmail.com%3E

Attached unit test and fix to DataFormatter.

Waiting for trunk to be unfrozen before committing.
Comment 2 Javen O'Neal 2016-09-11 03:38:32 UTC 
Applied in r1760219. This will likely be included in POI 3.15 final.