Bug 60069 - SamplerCreatorFactory.getSamplerCreator has two unused parameters
Summary: SamplerCreatorFactory.getSamplerCreator has two unused parameters
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 3.0
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-30 15:40 UTC by Sebb
Modified: 2016-09-17 12:22 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2016-08-30 15:40:37 UTC
The method org.apache.jmeter.protocol.http.proxy.SamplerCreatorFactory.getSamplerCreator only uses its first parameter - the two Map parameters are ignored.

The parameters could be dropped; or at least they could be documented as being ignored.
Comment 1 Sebb 2016-08-30 16:40:03 UTC
The interface method SamplerCreator.createSampler also does not need the encoding Map parameters
Comment 2 UbikLoadPack support 2016-09-03 09:15:46 UTC
Hello sebb,
If you intend to drop SamplerCreator.createSampler in the end, then you should first deprecate the one with 2 parameters and make it call the new one in next release , then drop the deprecated one in N+2 release.
Otherwise it will break plugins, for example we would be concerned by such modification.

Thank you for taking into account this request.

Regards