Bug 60137 - In Distributed testing when using StrippedXXXX modes strip response also on error
Summary: In Distributed testing when using StrippedXXXX modes strip response also on e...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.0
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-14 21:55 UTC by Philippe Mouawad
Modified: 2016-09-25 16:19 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2016-09-14 21:55:15 UTC
Currently DataStrippingSampleSender works this way:
- If Sample is successful, it strips SampleResult response and children responses

But if it is in failure, no stripping occurs.
It was initially done to allow reporting errors to controller for better debugging.

The problem with this is scalability when a lot of errors occur which can lead to OOM on Controller and slowdown jmeter-server.


I suggest the following:

- Add property sample_sender_strip_also_on_error which will default to true for performances
- When true, we strip whatever the status, if not we only strip successful responses

This will provide better scalability for next versions in case of high error rate and will still provide to users a way to debug distributed tests if they want at a lower rate.
Comment 1 Philippe Mouawad 2016-09-15 11:53:25 UTC
Author: pmouawad
Date: Thu Sep 15 11:52:24 2016
New Revision: 1760920

URL: http://svn.apache.org/viewvc?rev=1760920&view=rev
Log:
Bug 60137 - In Distributed testing when using StrippedXXXX modes strip response also on error
Bugzilla Id: 60137

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2016-09-25 16:19:16 UTC
Author: pmouawad
Date: Sun Sep 25 16:16:04 2016
New Revision: 1762219

URL: http://svn.apache.org/viewvc?rev=1762219&view=rev
Log:
Bug 60137 - In Distributed testing when using StrippedXXXX modes strip response also on error
Document sample_sender_strip_also_on_error
Bugzilla Id: 60137

Modified:
    jmeter/trunk/xdocs/usermanual/properties_reference.xml