Bug 60216 - [PATCH] Patch for Comment documentation
Summary: [PATCH] Patch for Comment documentation
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.16-dev
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2016-10-07 07:34 UTC by Daniel Küppers
Modified: 2016-10-10 15:37 UTC (History)
0 users

git diff patch (2.66 KB, patch)
2016-10-07 07:34 UTC, Daniel Küppers
Details | Diff
Full patch - passes conf suite (12.92 KB, patch)
2016-10-10 15:37 UTC, IgnacioHR
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Küppers 2016-10-07 07:34:36 UTC
Created attachment 34332 [details]
git diff patch

Hello everyone!
Supplying my first patch, hope the section is correct.
I noticed a documention twist of setVisible(boolean) and getVisible() and corrected that. I also updated the documentation from XSSFComment accordingly to Comment and HSSFComment.

Attachment is an uncompressed git diff file from revision 6dc4bcf1de.
Comment 1 Javen O'Neal 2016-10-07 12:39:36 UTC
Thanks for the javadocs fix! Applied in r1763757.
Comment 2 IgnacioHR 2016-10-10 15:37:20 UTC
Created attachment 34353 [details]
Full patch - passes conf suite