Bug 60489 - Add visio.ConnectsType class to ooxml-schemas
Summary: Add visio.ConnectsType class to ooxml-schemas
Alias: None
Product: POI
Classification: Unclassified
Component: XDGF (show other bugs)
Version: 3.16-dev
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2016-12-16 16:28 UTC by Tim Allison
Modified: 2017-03-23 16:57 UTC (History)
0 users

triggering file (43.38 KB, application/vnd.ms-visio.viewer)
2016-12-16 16:28 UTC, Tim Allison

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Allison 2016-12-16 16:28:31 UTC
Created attachment 34530 [details]
triggering file

On TIKA-2208, David Pilato shared a .vsdx that includes a class we aren't including in our stripped down ooxml-schemas: com.microsoft.schemas.office.visio.x2012.main.ConnectsType

Let's add that file to our unit tests to avoid ClassNotFoundException.

As a side note/question...I thought I remembered with xwpf, when a class wasn't found, we logged it but didn't throw a CNFE...am I remembering this correctly?

If this is the case, do we need to modify our vsdx code to handle this?
Comment 1 Javen O'Neal 2016-12-16 16:38:26 UTC
If the full ooxml-schemas is used, is a CNFE thrown (making sure that the 2006 schemas are sufficient).

Just add a unit test that includes ConnectsType and it will be included in poi-ooxml-schemas.
Comment 2 Tim Allison 2016-12-16 16:42:20 UTC
Y, adding the file to our unit tests fixes the problem.  Will commit shortly.  Thank you!

Larger question though...am I remembering incorrectly that we used to handle missing beans via logging instead of allowing the CNFE?  In short, does this point to a need to modify our ooxml-visio parser...or do we carry on with the current procedure...adding triggering files as people complain?
Comment 3 Tim Allison 2016-12-16 16:49:03 UTC

If we need to modify our ooxml visio parser to log missing beans rather than throwing a CNFE, let's open a separate issue.
Comment 4 Tim Allison 2016-12-16 16:49:19 UTC
Comment 5 Tim Allison 2017-03-23 16:57:05 UTC
Double, doh!

Needed to add @Test annotation to actually trigger the addition...