Bug 60727 - Drop commons-httpclient-3.1 and related elements
Summary: Drop commons-httpclient-3.1 and related elements
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 3.1
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on: 59038
Blocks:
  Show dependency tree
 
Reported: 2017-02-13 08:09 UTC by UbikLoadPack support
Modified: 2017-02-18 16:32 UTC (History)
1 user (show)



Attachments
Patch implementing feature (153.82 KB, patch)
2017-02-13 09:09 UTC, UbikLoadPack support
Details | Diff
Patch implementing feature (163.28 KB, patch)
2017-02-13 12:43 UTC, UbikLoadPack support
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description UbikLoadPack support 2017-02-13 08:09:35 UTC
Related to Bug 59038 and dev mailing list discussion:
"Drop Commons-HttpClient 3.1" http://mail-archives.apache.org/mod_mbox/jmeter-dev/201512.mbox/%3CCAH9fUpZ8WMA9MBZZ8vwG%3DjCH-HhaAi8TPSMSfQ6NKcESky%2BD5Q%40mail.gmail.com%3E

Drop:

   - HTTPHC3Impl
   - SoapSampler
   - HTTPSampler2 used by SoapSampler
   - HC3CookieHandler
   - HttpHC3Impl
   - LoopbackHttpClientSocketFactory
   - SlowHttpClientSocketFactory
Comment 1 UbikLoadPack support 2017-02-13 09:09:58 UTC
Created attachment 34751 [details]
Patch implementing feature

Hello,
Working on patch we saw that the Test Unit for Cache Manager and Java Impl was in fact partly using HTTPClient 3.1.

Regards
Comment 2 UbikLoadPack support 2017-02-13 12:43:02 UTC
Created attachment 34752 [details]
Patch implementing feature
Comment 3 Philippe Mouawad 2017-02-16 20:32:59 UTC
Author: pmouawad
Date: Thu Feb 16 20:32:35 2017
New Revision: 1783280

URL: http://svn.apache.org/viewvc?rev=1783280&view=rev
Log:
Bug 60727 - Drop commons-httpclient-3.1 and related elements
Contributed by UbikLoadPack support
Bugzilla Id: 60727

Removed:
    jmeter/trunk/bin/httpclient.parameters
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC3CookieHandler.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/gui/SoapSamplerGui.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC3Impl.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampler2.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/SoapSampler.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/LoopbackHttpClientSocketFactory.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/SlowHttpClientSocketFactory.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManagerHttpMethod.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestHC3CookieManager.java
Modified:
    jmeter/trunk/LICENSE
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/bin/saveservice.properties
    jmeter/trunk/bin/upgrade.properties
    jmeter/trunk/build.properties
    jmeter/trunk/build.xml
    jmeter/trunk/eclipse.classpath
    jmeter/trunk/lib/aareadme.txt
    jmeter/trunk/licenses/bin/README.txt
    jmeter/trunk/res/maven/ApacheJMeter_parent.pom
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
    jmeter/trunk/src/core/org/apache/jmeter/util/HttpSSLProtocolSocketFactory.java
    jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/CookieManager.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HC4CookieHandler.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBaseConverter.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerFactory.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HttpClientDefaultParameters.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManagerUrlConnection.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestCacheManagerUrlConnectionBase.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/sampler/TestHTTPSamplersAgainstHttpMirrorServer.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml
    jmeter/trunk/xdocs/usermanual/properties_reference.xml
Comment 4 Philippe Mouawad 2017-02-16 21:34:14 UTC
Author: pmouawad
Date: Thu Feb 16 21:32:02 2017
New Revision: 1783307

URL: http://svn.apache.org/viewvc?rev=1783307&view=rev
Log:
Bug 60727 - Drop commons-httpclient-3.1 and related elements
Fix test failure
Bugzilla Id: 60727

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerFactory.java
Comment 5 Philippe Mouawad 2017-02-17 19:54:49 UTC
Author: pmouawad
Date: Fri Feb 17 19:54:00 2017
New Revision: 1783456

URL: http://svn.apache.org/viewvc?rev=1783456&view=rev
Log:
Restore testloadAndSave

Modified:
    jmeter/trunk/bin/testfiles/SavedGenTest210.jmx
    jmeter/trunk/bin/testfiles/SavedGenTest27.jmx
    jmeter/trunk/bin/testfiles/SavedGenTest2_13.jmx
    jmeter/trunk/bin/testfiles/SavedGenTest3_0.jmx
    jmeter/trunk/bin/testfiles/SavedGuiTest.jmx
    jmeter/trunk/bin/testfiles/SavedGuiTest231.jmx
    jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
Comment 6 Philippe Mouawad 2017-02-18 16:32:30 UTC
Author: pmouawad
Date: Sat Feb 18 16:32:10 2017
New Revision: 1783570

URL: http://svn.apache.org/viewvc?rev=1783570&view=rev
Log:
Bug 60727 - Drop commons-httpclient-3.1 and related elements
Switch to HC4 if HC31
Bugzilla Id: 60727

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java