Bug 60857 - SaveService omits XML header if _file_encoding is not defined in saveservice.properties
Summary: SaveService omits XML header if _file_encoding is not defined in saveservice....
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.1
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-13 19:30 UTC by Sebb
Modified: 2017-03-13 22:56 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2017-03-13 19:30:46 UTC 
The method writeXmlHeader() omits the <?xml ...> header if the _file_encoding is not defined in saveservice.properties.
Comment 1 Sebb 2017-03-13 22:56:22 UTC 
URL: http://svn.apache.org/viewvc?rev=1786823&view=rev
Log:
SaveService omits XML header if _file_encoding is not defined in saveservice.properties
getFileEncodingCharset() no longer returns null, so can simplify calling code

Bugzilla Id: 60857

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 The ASF infrastructure team 2022-09-24 20:38:08 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4331