Bug 60879 - Handle xlsb (BETA) more cleanly
Summary: Handle xlsb (BETA) more cleanly
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: 3.16-dev
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-17 08:39 UTC by Tim Allison
Modified: 2017-03-20 18:56 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Allison 2017-03-17 08:39:57 UTC
This may actually be two separate issues.

1) While working on 60826, I found that at least one xlsb file in our unit tests is xlsb "BETA".  Excel 2016 refuses to open it: 

'"Simple.xlsb" cannot be opened because it was last saved using a Beta version of Excel that is no longer supported.  To open the file, first use a supported version of Excel to save the file and then try again.'

2) I thought I found an xlsb with a styles.xml instead of a styles.bin.  I'm not able to locate it now, but will update this issue when I find it.

The current xlsb parser isn't able to handle 1) or 2).  We should either fix it handle those or have it throw an exception.
Comment 1 Tim Allison 2017-03-20 18:56:08 UTC
I'm bailing on 2).  I can't find the file.  I'll blame flu-induced hallucinations.

On 1), it looks like there is a difference in the BrtBundleSh object.  Once we modify that to read the old version, the rest of Simple.xlsb parses.  We log/warn that the file was written by a beta version of Excel, and we hope for the best.

In the future, we may want to throw an Exception and give up. 

r1787832