60881 – Throw exception for encrypted xlsb

Bug 60881 - Throw exception for encrypted xlsb

Summary: Throw exception for encrypted xlsb

Status:	RESOLVED FIXED

Alias:	None

Product:	POI
Classification:	Unclassified
Component:	XSSF (show other bugs)
Version:	3.16-dev
Hardware:	PC All

Importance:	P2 enhancement (vote)
Target Milestone:	---
Assignee:	POI Developers List

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-03-17 12:42 UTC by Tim Allison
Modified:	2017-03-22 16:22 UTC (History)
CC List:	0 users

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Allison 2017-03-17 12:42:31 UTC

Comment 1 Tim Allison 2017-03-20 20:48:28 UTC

On further review, no need to throw an exception.  The same encryption/decryption method that works with xlsx works with xlsb.  I added a unit test with test file to confirm this.

Comment 2 Tim Allison 2017-03-20 20:48:39 UTC

r1787846

Comment 3 Tim Allison 2017-03-21 00:05:30 UTC

Broke the build with the new unit test. :( 

The test file requires unlimited jce.  I added an if clause that tests for unlimited JCE; if no unlimited JCE, skip the test.

r1787890

Comment 4 Javen O'Neal 2017-03-22 00:43:07 UTC

Use org.junut.Assume.assumeTrue(condition) so that the test is marked as skipped rather than passed.

Comment 5 Tim Allison 2017-03-22 16:22:04 UTC

r1788133

Thank you, Javen.