Bug 61062 - Various HPSF related fixes
Summary: Various HPSF related fixes
Alias: None
Product: POI
Classification: Unclassified
Component: HPSF (show other bugs)
Version: 3.17-dev
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2017-05-02 23:18 UTC by Andreas Beeker
Modified: 2017-05-03 19:21 UTC (History)
0 users


Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Beeker 2017-05-02 23:18:09 UTC
This is a container entry for various HPSF related fixes.
The patches are documented below...
Comment 1 Andreas Beeker 2017-05-02 23:46:17 UTC
Use LittleEndianStream instead of offset calculation:
the old implementation needed to update the offset value with every written fragment - using a the LittleEndianStream wraps that offset calculation.
Furthermore the 0-padding was ignored on some places, this has been fixed here too

IntegrationTest - move excludes to file handler:
the integration tests had all excludes in the TestAllFiles.
now the filename is also passed down to the handlers which enables the excluding inside the handlers

Fix hpsf javadocs and code issues:
the javadocs don't need to be html compliant - see http://www.oracle.com/technetwork/articles/java/index-137868.html
Furthermore there are some sonarcube code fixes and a mapper for locale ids

Enable new number types in VariantSupport:
Added a few more Variant mappings for number types

Add CopyCompare to IntegrationTests
Comment 2 Andreas Beeker 2017-05-03 19:21:56 UTC
HPSF: Change CustomProperties to delegate - r1793699
the old implementation (by extending HashMap) left a few open interpretations open, i.e when is a CustomProperty vs. an property value returned in the various Map methods.
I hope this is more clear now.