Bug 61235 - Remove org.apache.poi.hssf.record.RecordFormatException
Summary: Remove org.apache.poi.hssf.record.RecordFormatException
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: 3.17-dev
Hardware: PC Mac OS X 10.1
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 08:34 UTC by PJ Fanning
Modified: 2017-06-29 08:40 UTC (History)
0 users



Attachments
patch (29.79 KB, patch)
2017-06-29 08:34 UTC, PJ Fanning
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description PJ Fanning 2017-06-29 08:34:17 UTC
Created attachment 35089 [details]
patch

This class is marked for removal. There is an equivalent exception.
One issue is that there are a fair number of methods that throw the old exception and it's possible that it would be too much impact for us to remove the class.
I have a patch that demonstrates the impact on src/java.
If there are any concerns, please raise them.
If there are no objections, I will proceed with the removal
Comment 1 PJ Fanning 2017-06-29 08:40:51 UTC
Looking at the diff again, I don't think the impact is as large as I had initially thought.
The change is https://svn.apache.org/viewvc?view=revision&revision=1800249 - if there are any concerns, I can revert some or all of the change.