Bug 61399 - Make some bin and extras scripts Shellcheck compatible
Summary: Make some bin and extras scripts Shellcheck compatible
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.6
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-10 19:32 UTC by Wolfgang Wagner
Modified: 2017-08-26 13:09 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Wagner 2017-08-10 19:32:16 UTC 
Scripts in the bin and extras folder are not shellcheck compatible and report errors / warnings.
This is to track shellcheck compatibilty of the scripts.
Comment 1 Wolfgang Wagner 2017-08-10 19:35:01 UTC 
opened https://github.com/apache/jmeter/pull/304
Comment 2 Philippe Mouawad 2017-08-26 13:07:46 UTC 
Author: pmouawad
Date: Sat Aug 26 13:07:21 2017
New Revision: 1806293

URL: http://svn.apache.org/viewvc?rev=1806293&view=rev
Log:
Bug 61399 - Make some bin and extras scripts Shellcheck compatible
This closes #304
Contributed by Wolfgang Wagner
Bugzilla Id: 61399

Modified:
    jmeter/trunk/bin/heapdump.sh
    jmeter/trunk/bin/mirror-server
    jmeter/trunk/bin/mirror-server.sh
    jmeter/trunk/bin/shutdown.sh
    jmeter/trunk/bin/stoptest.sh
    jmeter/trunk/extras/proxycert.sh
    jmeter/trunk/xdocs/changes.xml
Comment 3 Philippe Mouawad 2017-08-26 13:09:25 UTC 
Thanks for your PR.
Sorry for time taken to merge it, but as you know we are in summer period and on holidays for some of us.

Feel free to test nightly build and give your feedback.
Thanks
Comment 4 The ASF infrastructure team 2022-09-24 20:38:09 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4464