Bug 61466 - Adding samplers comment to SamplerResult could be interesting for reporters
Summary: Adding samplers comment to SamplerResult could be interesting for reporters
Status: NEW
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-28 13:26 UTC by Vincent HERILIER
Modified: 2017-09-08 15:46 UTC (History)
2 users (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent HERILIER 2017-08-28 13:26:41 UTC
Publishing JMeter results directly under specific format like PerfPublisher is possible from reporter elements but the test details (comment) is hardly missing (especially the one of TransactionControllers) because not available in the SampleResult class.

Does this data miss on purpose (memory or performance issues) or could it be added to enhance JMeter to provide then more accurate reporters?

Sorry if the question was already rised and answered, but I don't find anything about it.

Thanks for your feedback.

--Vincent
Comment 1 Philippe Mouawad 2017-09-02 19:34:27 UTC
I suppose the issue is that it would be duplicated a huge number of times no ?

How do you see the feature ?

Thanks
Comment 2 Vincent HERILIER 2017-09-08 15:46:09 UTC
Hi Philippe,

I'm not sure for the duplication (in my case), but at least, if the Transaction Controller is able to "save" its comment (description) into its related SampleResult, it could be great enough.
PerfPublisher does only work on the usecase/testcase level, so the TransactionController is the right element to deal with it; the inner steps are not relevant for it (other sampler results).

So, if the SampleResult object may have a new "comment" (String) property (like the name) and always initialized as an empty one and related getter/setter.
The TransactionSampler can save its comment in its related sampleResult with 2 constructors to keep compatibility.
And the TransactionController just has to create a TransactionSampler with the name and the comment.

Other Sampler elements could receive the same feature but I do not need that currently.

I already have the code that I can propose in a PR.

Thank you for your feedbacks