Bug 61492 - Add the possibility to change the value of proxy.pause in the HTTP(S) Test Script Recorder GUI
Summary: Add the possibility to change the value of proxy.pause in the HTTP(S) Test Sc...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 3.2
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-05 19:20 UTC by Antonio Gomes Rodrigues
Modified: 2017-09-16 15:26 UTC (History)
2 users (show)



Attachments
Screenshot of the modified GUI (104.51 KB, image/png)
2017-09-05 19:20 UTC, Antonio Gomes Rodrigues
Details
Patch (9.19 KB, patch)
2017-09-05 20:20 UTC, Antonio Gomes Rodrigues
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes Rodrigues 2017-09-05 19:20:50 UTC
Created attachment 35295 [details]
Screenshot of the modified GUI

Hi,

The value of proxy.pause is by default to 5s
To modify it we need to modify property file.

I propose to allow to modify it in the HTTP(S) Test Script Recorder GUI

It will allow to adapt the value to the tested application without restarting JMeter

Antonio
Comment 1 Antonio Gomes Rodrigues 2017-09-05 20:20:32 UTC
Created attachment 35298 [details]
Patch
Comment 2 Philippe Mouawad 2017-09-05 20:38:29 UTC
Hi Antonio,
Thanks for patch.

My notes:
- SAMPLE_GAP should not be static anymore (and renamed)
- parsing should be Long.parseLong
- Why this code : proxyPauseHTTPSample.setText(proxyPauseHTTPSample.getText().substring(0, length-1));


Label ideas:

- Sample gaps to create transaction
- Create new transaction after request (ms)

Thanks
Comment 3 Antonio Gomes Rodrigues 2017-09-05 20:52:09 UTC
"(In reply to Philippe Mouawad from comment #2)
> Hi Antonio,
> Thanks for patch.
> 
> My notes:
> - SAMPLE_GAP should not be static anymore (and renamed)
Which name?

> - parsing should be Long.parseLong
OK

> - Why this code :
> proxyPauseHTTPSample.setText(proxyPauseHTTPSample.getText().substring(0,
> length-1));
It's when you write a non digit in the input. It allow to remove the non digit character (the last you have write)

> 
> 
> Label ideas:
> 
> - Sample gaps to create transaction
> - Create new transaction after request (ms)
I like this one

> 
> Thanks
Comment 4 Antonio Gomes Rodrigues 2017-09-07 10:37:54 UTC
I have commit the patch with a fix

Antonio
Comment 5 Milamber 2017-09-16 15:26:48 UTC
URL: http://svn.apache.org/viewvc?rev=1807583&view=rev
Log:
This closes #61492 : Add the possibility to change the value of proxy.pause in the HTTP(S) Test Script Recorder GUI

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/images/screenshots/proxy_control.png