Bug 61515 - Removing last slide then appending new slide leads to corrupted PowerPoint file
Summary: Removing last slide then appending new slide leads to corrupted PowerPoint file
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 3.16-FINAL
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-12 08:39 UTC by François Beaune
Modified: 2017-09-14 15:53 UTC (History)
0 users


Attachments
Minimal Java repro case (983 bytes, text/plain)
2017-09-12 08:39 UTC, François Beaune 		Details
Input file for the repro case (28.58 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2017-09-12 08:40 UTC, François Beaune 		Details
Output of the repro case (25.73 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2017-09-12 08:41 UTC, François Beaune 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description François Beaune 2017-09-12 08:39:24 UTC 
Created attachment 35318 [details]
Minimal Java repro case

Please find attached a minimal repro case that:

1. Loads a basic PowerPoint file with a single slide.
2. Removes that slides.
3. Appends a new slide.
4. Save the resulting document.

The document is reported as corrupted by PowerPoint 2013 and PowerPoint 2016 which propose to fix it.
Comment 1 François Beaune 2017-09-12 08:40:34 UTC 
Created attachment 35319 [details]
Input file for the repro case

This file is simply an unmodified blank document with a single slide, saved with PowerPoint 2013.
Comment 2 François Beaune 2017-09-12 08:41:08 UTC 
Created attachment 35320 [details]
Output of the repro case

This file is reported as corrupted by PowerPoint.
Comment 3 Alain Fagot Bearez 2017-09-13 17:24:54 UTC 
I just pushed a fix for this as pull request #70:

https://github.com/apache/poi/pull/70
Comment 4 PJ Fanning 2017-09-13 23:13:23 UTC 
https://svn.apache.org/viewvc?view=revision&revision=1808294 has been merged
Comment 5 François Beaune 2017-09-14 08:38:27 UTC 
Awesome, thank you very much!

Will the fix be part of the next release, which I presume is 3.17?
Comment 6 PJ Fanning 2017-09-14 10:14:04 UTC 
3.17 was released before this change was added.
Comment 7 François Beaune 2017-09-14 15:53:17 UTC 
I was under the impression that 3.17 final hadn't been released yet and that you would maybe fold this fix into the current or next beta. That said, it's of course fine if the fix is in 3.18.