Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles with read, browse, clear
Summary: JMS Point-to-Point Sampler: Enhance communication styles with read, browse, c...
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-20 08:55 UTC by Benny van Wijngaarden
Modified: 2017-11-27 18:18 UTC (History)
2 users (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benny van Wijngaarden 2017-09-20 08:55:52 UTC
The JMS Point-to-Point Sampler only supports the communication styles Request Only and Request Response.
It would be very convenient if the following options were added:
- Read - reads a message from the queue (if any)
- Browse - return the current queue depth ie. number of messages on queue
- Clear - clear the queue ie. remove all messages from queue

In addition, when this sampler is able to read messages from a queue, the setting for 'Number of samples to aggregate' should be introduced, like the JMS Subscriber Sampler offers.
Comment 1 Benny van Wijngaarden 2017-09-20 11:09:18 UTC
Additional info:
One might ask why the JMS Subscriber Sampler is not used for reading from a queue. My reason is as follows: We use JMeter to handle queues without a binding file. As far as I know this construct, using the skip-jndi jar, only works with the JMS Point-to-Point sampler.
Comment 2 Philippe Mouawad 2017-11-18 20:15:41 UTC
Author: pmouawad
Date: Sat Nov 18 20:15:20 2017
New Revision: 1815692

URL: http://svn.apache.org/viewvc?rev=1815692&view=rev
Log:
Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles with read, browse, clear
Bugzilla Id: 61544

Modified:
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSamplerGui.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml
Comment 3 Philippe Mouawad 2017-11-18 21:39:55 UTC
Author: pmouawad
Date: Sat Nov 18 21:39:34 2017
New Revision: 1815698

URL: http://svn.apache.org/viewvc?rev=1815698&view=rev
Log:
Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles with read, browse, clear
This closes #325
Fix persistence and add tests
Bugzilla Id: 61544

Modified:
    jmeter/trunk/bin/testfiles/JMS_TESTS.csv
    jmeter/trunk/bin/testfiles/JMS_TESTS.jmx
    jmeter/trunk/bin/testfiles/JMS_TESTS.xml
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSamplerGui.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
Comment 4 Philippe Mouawad 2017-11-18 22:18:44 UTC
Thanks for your PR , I integrated with following changes:
- Made it backward compatible
- Used codes for different modes (not labels to avoid issues when switching between languages) and enum instead of only numerical constants
Comment 5 Philippe Mouawad 2017-11-19 10:01:33 UTC
Author: pmouawad
Date: Sun Nov 19 10:00:27 2017
New Revision: 1815716

URL: http://svn.apache.org/viewvc?rev=1815716&view=rev
Log:
Bug 61544 - JMS Point-to-Point Sampler: Enhance communication styles with read, browse, clear
Fix test : Increase timeout that was set to 1ms which led to random failure
Improve class code (logging, variable naming, use StringBuilder)
Bugzilla Id: 61544

Modified:
    jmeter/trunk/bin/testfiles/JMS_TESTS.csv
    jmeter/trunk/bin/testfiles/JMS_TESTS.jmx
    jmeter/trunk/bin/testfiles/JMS_TESTS.xml
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
Comment 6 Philippe Mouawad 2017-11-27 18:18:29 UTC
Author: pmouawad
Date: Mon Nov 27 18:18:01 2017
New Revision: 1816483

URL: http://svn.apache.org/viewvc?rev=1816483&view=rev
Log:
Bug 61544 : JMS Point-to-Point Sampler: Enhance communication styles with read, browse, clear
Fix response message erased, hiding potential interesting information.
Fix issue when timeout is empty, "" value will be used instead of default value leading to error
Bugzilla Id: 61544

Modified:
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java