Bug 61591 - UX : Remove Workbench
Summary: UX : Remove Workbench
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-07 14:01 UTC by Philippe Mouawad
Modified: 2017-11-21 21:56 UTC (History)
3 users (show)



Attachments
Remove WorkBench patch (29.11 KB, patch)
2017-11-14 13:51 UTC, Artem Fedorov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2017-10-07 14:01:00 UTC
Workbench element should be removed in order to simplify UX.

The only advantage of this element is Non Test Elements which would be made available from Test Plan directly.

When running a test those element would not impact test plan.
Comment 1 Artem Fedorov 2017-11-14 13:51:40 UTC
Created attachment 35527 [details]
Remove WorkBench patch
Comment 2 Philippe Mouawad 2017-11-14 17:30:50 UTC
Hello Artem,
Thanks for your patch, would it be possible to provide a PR instead ?
It would allow us a better review and non regression tests are ran on the patch.

If you can't I'll do without it.

Regards
Comment 3 Andrey Pokhilko 2017-11-14 18:16:20 UTC
How can we avoid double effort? The "official" way to provide patch is to attach it to bugzilla. Now you require to create PR on GitHub, but GitHub PR is only for review, still disconnected from actual SVN repository. This process feels messy and discourages contributions...
Comment 4 Philippe Mouawad 2017-11-14 18:23:29 UTC
(In reply to Andrey Pokhilko from comment #3)
> How can we avoid double effort? The "official" way to provide patch is to
> attach it to bugzilla. Now you require to create PR on GitHub, but GitHub PR
> is only for review, still disconnected from actual SVN repository. This
> process feels messy and discourages contributions...

Hi Andrey,
Historically we favored patches. 
But we introduced PRs recently as long as Travis CI, they have a lot of advantages as you know (review, now code coverage impact check, automated tests...). 

That's why I asked here for it, BUT I said that I would take it as is if you don't want to provide a PR.

In summary, for next contributions, it would be nice to favor PR.
But for now, unless you want to make a PR, I'll take it as is.


PS : Do you really feel with all the efforts made on review, CI, ...  we discourage contributions ?
Comment 6 Andrey Pokhilko 2017-11-14 18:41:45 UTC
I re-checked the contributing page (http://jmeter.apache.org/building.html) and found that now the first option we mention is GitHub way. This means my intent to go with patches is outdated.

There is no problem with creating a PR, we'll do it soon. 

From my experience, the best thing is to require _only_ PR from contributors. PR on GitHub is perfect place for discussion, as it is contextual with the code. Also, discussion happens _before_ code merged, so it eliminates the post-commit investigations on dev mailing list.

Requirement to interact with Bugzilla reveals ugly nineties-style issue tracker, it serves bad reputation for us. IMO we should remove this requirement from contributors. If we need bugzillas, we (core maintainers) better create them ourselves. Working with SVN also don't manifest project as modern. 

But all of this were discussed so many times, and we had no decision to change this. I am ok with that, reasons make sense.
Comment 7 Artem Fedorov 2017-11-15 10:16:41 UTC
Added PR: https://github.com/apache/jmeter/pull/330

Attachment 35527 [details] is deprecated
Comment 8 Philippe Mouawad 2017-11-15 21:01:21 UTC
Author: pmouawad
Date: Wed Nov 15 21:00:51 2017
New Revision: 1815374

URL: http://svn.apache.org/viewvc?rev=1815374&view=rev
Log:
Bug 61591 - UX : Remove Workbench
Contributed by Artem Fedorov with modifications to fix the Popup Menu on the Non Test Elements that allows actions that are meaningless now
This closes #330
Bugzilla Id: 61591

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/control/gui/TestPlanGui.java
    jmeter/trunk/src/core/org/apache/jmeter/control/gui/WorkBenchGui.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Load.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Move.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
    jmeter/trunk/src/core/org/apache/jmeter/testelement/WorkBench.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/gui/HttpMirrorControlGui.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/build-test-plan.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml
Comment 9 Antonio Gomes Rodrigues 2017-11-20 21:54:24 UTC
Date: Mon Nov 20 21:52:55 2017
New Revision: 1815862

URL: http://svn.apache.org/viewvc?rev=1815862&view=rev
Log:
[Bug 61591] Replace template_menu.png from get-started.html

Modified:
    jmeter/trunk/xdocs/images/screenshots/template_menu.png
Comment 10 Antonio Gomes Rodrigues 2017-11-20 22:37:02 UTC
New Revision: 1815865

URL: http://svn.apache.org/viewvc?rev=1815865&view=rev
Log:
[Bug 61591] Update build-web-test-plan documentation (image and text)

Modified:
    jmeter/trunk/xdocs/images/screenshots/webtest/http-defaults1.png
    jmeter/trunk/xdocs/images/screenshots/webtest/http-defaults2.png
    jmeter/trunk/xdocs/images/screenshots/webtest/http-request1.png
    jmeter/trunk/xdocs/images/screenshots/webtest/http-request2.png
    jmeter/trunk/xdocs/images/screenshots/webtest/http_login.png
    jmeter/trunk/xdocs/images/screenshots/webtest/threadgroup.png
    jmeter/trunk/xdocs/images/screenshots/webtest/threadgroup2.png
    jmeter/trunk/xdocs/usermanual/build-web-test-plan.xml
Comment 11 Milamber 2017-11-21 19:19:57 UTC
Some issues:

1/ If you add a HTTP(S) Test Script Recorder to the Test Plan, that's works. But if you make a cut (ctrl-x) and try to paste (ctrl-p) to the Test Plan : don't works

2/ Before when the workbench exists, you can do this: add a HTTP(S) Test Script Recorder to Workbench, and move the HTTP(S) Test Script Recorder into a Test Fragment element. (I follow this way to save my 'proxy elements (recorder, view result tree, recording controller, etc)' before the behavior to save workbench into the jmx file

I thinks that would be better to change the old jmx file with a save workbench to replace the workbench with a Test Fragment, and keep sub-elements inside.
Comment 12 Philippe Mouawad 2017-11-21 19:32:34 UTC
(In reply to Milamber from comment #11)
> Some issues:
> 
> 1/ If you add a HTTP(S) Test Script Recorder to the Test Plan, that's works.
> But if you make a cut (ctrl-x) and try to paste (ctrl-p) to the Test Plan :
> don't works
> 
> 2/ Before when the workbench exists, you can do this: add a HTTP(S) Test
> Script Recorder to Workbench, and move the HTTP(S) Test Script Recorder into
> a Test Fragment element. (I follow this way to save my 'proxy elements
> (recorder, view result tree, recording controller, etc)' before the behavior
> to save workbench into the jmx file
> 
> I thinks that would be better to change the old jmx file with a save
> workbench to replace the workbench with a Test Fragment, and keep
> sub-elements inside.

This is not clear for me, can you clarify what you want ?
Comment 13 Philippe Mouawad 2017-11-21 20:10:10 UTC
Author: pmouawad
Date: Tue Nov 21 20:00:29 2017
New Revision: 1815976

URL: http://svn.apache.org/viewvc?rev=1815976&view=rev
Log:
Bug 61591 - UX : Remove Workbench
Allow moving and copying Test Script Recorder under test plan
Allow moving and copying Test Script Recorder under Test Fragment
Bugzilla Id: 61591

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
    
Author: pmouawad
Date: Tue Nov 21 20:08:52 2017
New Revision: 1815979

URL: http://svn.apache.org/viewvc?rev=1815979&view=rev
Log:
Bug 61591 - UX : Remove Workbench
Allow moving and copying Test Script Recorder under test plan
Allow moving and copying Test Script Recorder under Test Fragment
Bugzilla Id: 61591

Added:
    jmeter/trunk/src/core/org/apache/jmeter/testelement/NonTestElement.java   (with props)
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorServer.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java
Comment 14 Antonio Gomes Rodrigues 2017-11-21 21:55:07 UTC
New Revision: 1815991

URL: http://svn.apache.org/viewvc?rev=1815991&view=rev
Log:
[Bug 61591] Update jmeter_proxy_step_by_step (image and text)

Modified:
    jmeter/trunk/xdocs/images/screenshots/Proxy_Run.png
    jmeter/trunk/xdocs/images/screenshots/Select-Templates-Icon.png
    jmeter/trunk/xdocs/images/screenshots/Test_Generated.png
    jmeter/trunk/xdocs/images/screenshots/Validate-Test-Plan.png
    jmeter/trunk/xdocs/images/screenshots/example-recording.png
    jmeter/trunk/xdocs/images/screenshots/example-thread-group.png
    jmeter/trunk/xdocs/images/screenshots/http-config/http-request-defaults.png
    jmeter/trunk/xdocs/usermanual/jmeter_proxy_step_by_step.xml
Comment 15 Antonio Gomes Rodrigues 2017-11-21 21:56:38 UTC
New Revision: 1815993

URL: http://svn.apache.org/viewvc?rev=1815993&view=rev
Log:
[Bug 61591] Update templates : recording-with-think-time and recording

Modified:
    jmeter/trunk/bin/templates/recording-with-think-time.jmx
    jmeter/trunk/bin/templates/recording.jmx