Bug 61607 - Add browse button in all beanshell element
Summary: Add browse button in all beanshell element
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-11 21:48 UTC by Antonio Gomes Rodrigues
Modified: 2017-11-21 21:56 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes Rodrigues 2017-10-11 21:48:18 UTC
Hi,

I propose to add browser button to all beanshell elements

Antonio
Comment 1 Antonio Gomes Rodrigues 2017-10-11 21:52:28 UTC
New Revision: 1811895

URL: http://svn.apache.org/viewvc?rev=1811895&view=rev
Log:
Bug61607 Add browse button in all beanshell elements to select beanshell script

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/BeanShellAssertionGui.java
    jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/control/gui/BeanShellSamplerGui.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2017-10-11 22:03:17 UTC
Hi Antonio,
Although browse is nice there are big drawbacks when you variabilize this field.

You need to select Edit in combo,
you enter something then save
Try then to update it and save, your data is deleted.

So UX is weird.

As I usually only variabilize those usung __P  it ends up being less ux friendly than before particularly for CSV Dataset
Comment 3 Antonio Gomes Rodrigues 2017-10-11 22:19:53 UTC
Hi Philippe,

I don't understand your problem

In my Linux machine I don't need to select Edit in combo to variabilize this field

If I modify the field already variabilized, I just need to change of field or push enter before save it to avoid the change of the modification

Antonio
Comment 4 Antonio Gomes Rodrigues 2017-11-17 21:07:58 UTC
New Revision: 1815627

URL: http://svn.apache.org/viewvc?rev=1815627&view=rev
Log:
Bug 61607 : Fix Beanshel GUI bug

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java?rev=1815627&r1=1815626&r2=1815627&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java Fri Nov 17 21:04:45 2017
@@ -51,13 +51,14 @@ public abstract class BeanShellBeanInfoS
         p = property("filename");
         p.setValue(NOT_UNDEFINED, Boolean.TRUE);
         p.setValue(DEFAULT, "");
+        p.setPropertyEditorClass(FileEditor.class);

         createPropertyGroup("filenameGroup", new String[] { "filename" });

         p = property("script");
         p.setValue(NOT_UNDEFINED, Boolean.TRUE);
         p.setValue(DEFAULT, "");
-        p.setPropertyEditorClass(FileEditor.class);
+        p.setPropertyEditorClass(TextAreaEditor.class);

         createPropertyGroup("scripting", new String[] { "script" });
     }
Comment 5 Antonio Gomes Rodrigues 2017-11-21 21:55:27 UTC
New Revision: 1815993

URL: http://svn.apache.org/viewvc?rev=1815993&view=rev
Log:
[Bug 61591] Update templates : recording-with-think-time and recording

Modified:
    jmeter/trunk/bin/templates/recording-with-think-time.jmx
    jmeter/trunk/bin/templates/recording.jmx
Comment 6 Antonio Gomes Rodrigues 2017-11-21 21:56:21 UTC
Bad comment

Sorry
Antonio