As per discussion on dev mailing list: "Integrating Darcula LAF as JMeter main LAF"
Author: pmouawad Date: Mon Oct 30 20:30:04 2017 New Revision: 1813826 URL: http://svn.apache.org/viewvc?rev=1813826&view=rev Log: Bug 61697 - Introduce Darcula Look And Feel to make JMeter UI more attractive Bugzilla Id: 61697 Modified: jmeter/trunk/LICENSE jmeter/trunk/build.properties jmeter/trunk/build.xml jmeter/trunk/eclipse.classpath jmeter/trunk/lib/ (props changed) jmeter/trunk/lib/aareadme.txt jmeter/trunk/src/core/org/apache/jmeter/gui/action/LookAndFeelCommand.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java jmeter/trunk/xdocs/changes.xml
Author: pmouawad Date: Mon Oct 30 21:13:58 2017 New Revision: 1813831 URL: http://svn.apache.org/viewvc?rev=1813831&view=rev Log: Bug 61697 - Introduce Darcula Look And Feel to make JMeter UI more attractive Fix tests Bugzilla Id: 61697 Modified: jmeter/trunk/LICENSE jmeter/trunk/test/src/org/apache/jmeter/JMeterVersionTest.java
Author: pmouawad Date: Sun Nov 19 10:46:52 2017 New Revision: 1815724 URL: http://svn.apache.org/viewvc?rev=1815724&view=rev Log: Bug 61697 - Introduce Darcula Look And Feel to make JMeter UI more attractive Install LAF correctly Change Preference name so that previous chosen preferences does not hide this new feature Remove overriden settings in JMeter Bugzilla Id: 61697 Modified: jmeter/trunk/bin/jmeter.properties jmeter/trunk/src/core/org/apache/jmeter/gui/action/LookAndFeelCommand.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java
Author: pmouawad Date: Tue Nov 21 12:32:33 2017 New Revision: 1815915 URL: http://svn.apache.org/viewvc?rev=1815915&view=rev Log: Bug 61697 - Introduce Darcula Look And Feel to make JMeter UI more attractive Bugzilla Id: 61697 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/LookAndFeelCommand.java
Author: pmouawad Date: Thu Nov 23 14:04:45 2017 New Revision: 1816155 URL: http://svn.apache.org/viewvc?rev=1816155&view=rev Log: Bug 61697 Introduce Darcula Look And Feel to make JMeter UI more attractive Bugzilla Id: 61697 Added: jmeter/trunk/src/core/org/apache/jmeter/gui/util/theme/ jmeter/trunk/src/core/org/apache/jmeter/gui/util/theme/darcula_theme.xml (with props) Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/JSyntaxTextArea.java
Created attachment 35551 [details] Theme for Darcula by Philippe
Created attachment 35552 [details] Darcula theme proposal by Maxime
My theme is based on : http://www.eclipsecolorthemes.org/?view=theme&id=14105 Interesting and useful links: https://github.com/bobbylight/RSyntaxTextArea/blob/master/src/main/resources/org/fife/ui/rsyntaxtextarea/themes/theme.dtd https://github.com/bobbylight/RSyntaxTextArea/blob/master/src/main/resources/org/fife/ui/rsyntaxtextarea/themes/dark.xml https://github.com/JetBrains/intellij-community/blob/master/platform/platform-impl/src/com/intellij/ide/ui/laf/darcula/darcula.properties
Created attachment 35553 [details] Dark Theme present in JSyntaxTextArea
Created attachment 35554 [details] Monokai Theme
Hi, In Windows I can't execute JMeter in the last nighty build (r1816194) I have 2017-11-24 11:38:27,570 ERROR o.a.j.g.u.JSyntaxTextArea: Error reading darcula_theme for JSyntaxTextArea java.io.IOException: java.io.IOException: Stream closed at org.fife.ui.rsyntaxtextarea.Theme$XmlHandler.load(Theme.java:624) ~[rsyntaxtextarea-2.6.1.jar:2.6.1] at org.fife.ui.rsyntaxtextarea.Theme.load(Theme.java:355) ~[rsyntaxtextarea-2.6.1.jar:2.6.1] at org.fife.ui.rsyntaxtextarea.Theme.load(Theme.java:333) ~[rsyntaxtextarea-2.6.1.jar:2.6.1] at org.apache.jmeter.gui.util.JSyntaxTextArea.initTheme(JSyntaxTextArea.java:266) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.util.JSyntaxTextArea.<clinit>(JSyntaxTextArea.java:45) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.functions.gui.FunctionHelper.init(FunctionHelper.java:124) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.functions.gui.FunctionHelper.<init>(FunctionHelper.java:80) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.action.CreateFunctionDialog.<init>(CreateFunctionDialog.java:37) [ApacheJMeter_core.jar:r1816194] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_144] at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) [?:1.8.0_144] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) [?:1.8.0_144] at java.lang.reflect.Constructor.newInstance(Unknown Source) [?:1.8.0_144] at java.lang.Class.newInstance(Unknown Source) [?:1.8.0_144] at org.apache.jmeter.gui.action.ActionRouter.populateCommandMap(ActionRouter.java:372) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.JMeter.startGui(JMeter.java:371) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.JMeter.start(JMeter.java:522) [ApacheJMeter_core.jar:r1816194] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_144] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_144] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_144] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144] at org.apache.jmeter.NewDriver.main(NewDriver.java:248) [ApacheJMeter.jar:r1816194] 2017-11-24 11:38:27,661 ERROR o.a.j.g.a.ActionRouter: exception finding action handlers java.lang.NullPointerException: null at org.apache.jmeter.gui.util.JSyntaxTextArea.applyTheme(JSyntaxTextArea.java:118) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.util.JSyntaxTextArea.getInstance(JSyntaxTextArea.java:78) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.util.JSyntaxTextArea.getInstance(JSyntaxTextArea.java:139) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.functions.gui.FunctionHelper.init(FunctionHelper.java:124) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.functions.gui.FunctionHelper.<init>(FunctionHelper.java:80) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.action.CreateFunctionDialog.<init>(CreateFunctionDialog.java:37) ~[ApacheJMeter_core.jar:r1816194] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:1.8.0_144] at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_144] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) ~[?:1.8.0_144] at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[?:1.8.0_144] at java.lang.Class.newInstance(Unknown Source) ~[?:1.8.0_144] at org.apache.jmeter.gui.action.ActionRouter.populateCommandMap(ActionRouter.java:372) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.JMeter.startGui(JMeter.java:371) [ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.JMeter.start(JMeter.java:522) [ApacheJMeter_core.jar:r1816194] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_144] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_144] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_144] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144] at org.apache.jmeter.NewDriver.main(NewDriver.java:248) [ApacheJMeter.jar:r1816194] 2017-11-24 11:38:27,786 ERROR o.a.j.JMeter: An error occurred: java.lang.NullPointerException: null at org.apache.jmeter.gui.util.JSyntaxTextArea.applyTheme(JSyntaxTextArea.java:118) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.util.JSyntaxTextArea.getInstance(JSyntaxTextArea.java:78) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.LoggerPanel.init(LoggerPanel.java:84) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.LoggerPanel.<init>(LoggerPanel.java:74) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.MainFrame.createLoggerPanel(MainFrame.java:614) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.MainFrame.init(MainFrame.java:512) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.gui.MainFrame.<init>(MainFrame.java:220) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.JMeter.startGui(JMeter.java:376) ~[ApacheJMeter_core.jar:r1816194] at org.apache.jmeter.JMeter.start(JMeter.java:522) [ApacheJMeter_core.jar:r1816194] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_144] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_144] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_144] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144] at org.apache.jmeter.NewDriver.main(NewDriver.java:248) [ApacheJMeter.jar:r1816194]
Author: pmouawad Date: Fri Nov 24 11:11:24 2017 New Revision: 1816230 URL: http://svn.apache.org/viewvc?rev=1816230&view=rev Log: Bug 61697 Introduce Darcula Look And Feel to make JMeter UI more attractive Forgot to commit the xml addition to jar Bugzilla Id: 61697 Modified: jmeter/trunk/build.xml
Hi Antonio, I had forgotten a commit. Can you test again and give your feedback on different proposals ? Thanks
Work fine in Windows now Thank Antonio
Created attachment 35563 [details] Screenshot showing a slight bug on Mac where the titles of columns are not displayed There is non blocker bug in Darcula LAF where in File Chooser the column titles show label keys
Author: pmouawad Date: Sat Dec 30 14:15:08 2017 New Revision: 1819606 URL: http://svn.apache.org/viewvc?rev=1819606&view=rev Log: Bug 61697 Introduce Darcula Look And Feel to make JMeter UI more attractive Change highlight color as it makes text unreadable with Darcula LAF Bugzilla Id: 61697 Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/SearchTextExtension.java
Author: pmouawad Date: Thu Jan 11 22:17:36 2018 New Revision: 1820936 URL: http://svn.apache.org/viewvc?rev=1820936&view=rev Log: Bug 61697 - Introduce Darcula Look And Feel to make JMeter UI more attractive Matched brackets are not visible, fix that Bugzilla Id: 61697 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/theme/darcula_theme.xml
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4553