Bug 61742 - BackendListener : fix default value for backend_graphite.send_interval
Summary: BackendListener : fix default value for backend_graphite.send_interval
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-10 11:31 UTC by Zsolt Kecskemeti
Modified: 2017-11-10 12:38 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Kecskemeti 2017-11-10 11:31:54 UTC
Jmeter.properties suggest the default value is 1 second for backend_graphite.send_interval:

########################
# Graphite Backend
########################
# Send interval in second
# Defaults to 1 second
#backend_graphite.send_interval=1


Also a comment in GraphiteBackendListenerClient.java suggests it needs to be 1 second:

    public void setupTest(BackendListenerContext context) throws Exception {
        ...


        // Don't change this as metrics are per second
        this.timerHandle = scheduler.scheduleAtFixedRate(this, SEND_INTERVAL, SEND_INTERVAL, TimeUnit.SECONDS);
    }

but the default for SEND_INTERVAL is 5 seconds in the code:

    private static final long SEND_INTERVAL = JMeterUtils.getPropDefault("backend_graphite.send_interval", 5);

The good bit is that it's easy to fix temporarily (until it is fixed in the code) by actually uncommenting/setting backend_graphite.send_interval=1.

Why is this a problem? When creating graphs to display request per second metric (using either the a.count, h.count, ok.count, or ko.count) the numbers are inflated to those of 5 second window when using defaults.

This bugs seems to be introduced with the addition of timeboxed sliding window feature.

We noticed the change when we upgraded JMeter from 3.1 to 3.3. Without changing any of the relevant settings our graphs showing x.count stats jumped to x5 of their previous values.
Comment 1 Philippe Mouawad 2017-11-10 12:38:02 UTC
Thanks for report !
Fixed, you should be able to test it using nightly build.




Author: pmouawad
Date: Fri Nov 10 12:36:19 2017
New Revision: 1814839

URL: http://svn.apache.org/viewvc?rev=1814839&view=rev
Log:
Bug 61742: BackendListener : fix default value for backend_graphite.send_interva
Bugzilla Id: 61742

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteBackendListenerClient.java
    jmeter/trunk/xdocs/changes.xml