Bug 61771 - SwitchController : Switch field should be trimmed by safety
Summary: SwitchController : Switch field should be trimmed by safety
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-16 22:19 UTC by Philippe Mouawad
Modified: 2018-01-06 21:22 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2017-11-16 22:19:07 UTC
If you introduce by error a space at end of before the switch value, it can be hard to find the problem for the concerned switch.

I see no reason why a space would be here.

So I suggest we do a trim on field.
Comment 1 Graham Russell 2017-11-16 22:48:53 UTC
I agree, it is much more likely that trailing whitespace is a mistake, so should be the default to trim, as long as it's documented.
Comment 2 Philippe Mouawad 2018-01-06 21:22:27 UTC
Author: pmouawad
Date: Sat Jan  6 21:21:42 2018
New Revision: 1820422

URL: http://svn.apache.org/viewvc?rev=1820422&view=rev
Log:
Bug 61771 - SwitchController : Switch field should be trimmed by safety
Bugzilla Id: 61771

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/control/SwitchController.java
    jmeter/trunk/xdocs/changes.xml
Author: pmouawad
Date: Sat Jan  6 21:22:05 2018
New Revision: 1820423

URL: http://svn.apache.org/viewvc?rev=1820423&view=rev
Log:
Bug 61771 - SwitchController : Switch field should be trimmed by safety
Add tests
Bugzilla Id: 61771

Modified:
    jmeter/trunk/test/src/org/apache/jmeter/control/TestSwitchController.java