61867 – Updated to latest checkstyle (v8.5), Added many more rules to checkstyle, Included checking of test files and more file types.

Bug 61867 - Updated to latest checkstyle (v8.5), Added many more rules to checkstyle, Included checking of test files and more file types.

Summary: Updated to latest checkstyle (v8.5), Added many more rules to checkstyle, Inc...

Status:	RESOLVED FIXED

Alias:	None

Product:	JMeter - Now in Github
Classification:	Unclassified
Component:	Main (show other bugs)
Version:	3.3
Hardware:	PC Linux

Importance:	P2 enhancement (vote)
Target Milestone:	---
Assignee:	JMeter issues mailing list

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-12-06 22:23 UTC by Antonio Gomes Rodrigues
Modified:	2017-12-06 22:27 UTC (History)
CC List:	0 users

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Antonio Gomes Rodrigues 2017-12-06 22:23:57 UTC

New Revision: 1817321

URL: http://svn.apache.org/viewvc?rev=1817321&view=rev
Log:
This closes #345 - Updated to latest checkstyle (v8.5), Added many more rules to checkstyle, Included checking of test files and more file types. Contributed by Graham Russell

Modified:
    jmeter/trunk/build.properties
    jmeter/trunk/build.xml
    jmeter/trunk/checkstyle-suppressions.xml
    jmeter/trunk/checkstyle.xml
    jmeter/trunk/docs/images/screenshots/Proxy_Run.png
    jmeter/trunk/docs/images/screenshots/Select-Templates-Icon.png
    jmeter/trunk/docs/images/screenshots/Test_Generated.png
    jmeter/trunk/docs/images/screenshots/Validate-Test-Plan.png
    jmeter/trunk/docs/images/screenshots/example-recording.png
    jmeter/trunk/docs/images/screenshots/example-thread-group.png
    jmeter/trunk/docs/images/screenshots/http-config/http-request-defaults.png
    jmeter/trunk/docs/images/screenshots/template_menu.png
    jmeter/trunk/docs/images/screenshots/webtest/http-defaults1.png
    jmeter/trunk/docs/images/screenshots/webtest/http-defaults2.png
    jmeter/trunk/docs/images/screenshots/webtest/http-request1.png
    jmeter/trunk/docs/images/screenshots/webtest/http-request2.png
    jmeter/trunk/docs/images/screenshots/webtest/http_login.png
    jmeter/trunk/docs/images/screenshots/webtest/threadgroup.png
    jmeter/trunk/docs/images/screenshots/webtest/threadgroup2.png
    jmeter/trunk/src/components/org/apache/jmeter/assertions/JSONPathAssertion.java
    jmeter/trunk/src/components/org/apache/jmeter/assertions/ResponseAssertion.java
    jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/BeanShellAssertionGui.java
    jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/JSONPathAssertionGui.java
    jmeter/trunk/src/components/org/apache/jmeter/control/ThroughputController.java
    jmeter/trunk/src/components/org/apache/jmeter/extractor/gui/HtmlExtractorGui.java
    jmeter/trunk/src/components/org/apache/jmeter/extractor/json/jsonpath/JSONManager.java
    jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/Graph.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXML.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderInBrowser.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/BackendListener.java
    jmeter/trunk/src/core/org/apache/jmeter/NewDriver.java
    jmeter/trunk/src/core/org/apache/jmeter/assertions/gui/AbstractAssertionGui.java
    jmeter/trunk/src/core/org/apache/jmeter/config/gui/SimpleConfigGui.java
    jmeter/trunk/src/core/org/apache/jmeter/functions/gui/FunctionHelper.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/GlobalUndoableEdit.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/UndoHistoryItem.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/HorizontalPanel.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/PowerTableModel.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/VerticalPanel.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/util/theme/darcula_theme.xml
    jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleBuilder.java
    jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleMetaDataParser.java
    jmeter/trunk/src/core/org/apache/jmeter/report/core/SampleWriter.java
    jmeter/trunk/src/core/org/apache/jmeter/report/dashboard/TemplateVisitor.java
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/FilterConsumer.java
    jmeter/trunk/src/core/org/apache/jmeter/report/processor/TaggerConsumer.java
    jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollectorHelper.java
    jmeter/trunk/src/core/org/apache/jmeter/reporters/gui/ResultActionGui.java
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/core/org/apache/jmeter/samplers/AsynchSampleSender.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSenderFactory.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/StatisticalSampleSender.java
    jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java
    jmeter/trunk/src/core/org/apache/jmeter/save/ScriptWrapperConverter.java
    jmeter/trunk/src/core/org/apache/jmeter/save/converters/HashTreeConverter.java
    jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TableEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TypeEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/WrapperEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testelement/property/AbstractProperty.java
    jmeter/trunk/src/core/org/apache/jmeter/testelement/property/NumberProperty.java
    jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterVariables.java
    jmeter/trunk/src/core/org/apache/jmeter/util/BeanShellBeanInfoSupport.java
    jmeter/trunk/src/core/org/apache/jmeter/util/Calculator.java
    jmeter/trunk/src/core/org/apache/jmeter/util/CustomX509TrustManager.java
    jmeter/trunk/src/core/org/apache/jmeter/util/HostNameSetter.java
    jmeter/trunk/src/core/org/apache/jmeter/util/JMeterUtils.java
    jmeter/trunk/src/core/org/apache/jmeter/util/JSR223BeanInfoSupport.java
    jmeter/trunk/src/core/org/apache/jmeter/util/JsseSSLManager.java
    jmeter/trunk/src/examples/org/apache/jmeter/examples/sampler/gui/ExampleSamplerGui.java
    jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example3/Example3.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/DigestEncodeFunction.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/JavaScript.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/Jexl2Function.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/LogFunction.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/SplitFunction.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/StringFromFile.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/Uuid.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/XPath.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/collections/Data.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/gui/MenuScroller.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ObjectTableModel.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/math/StatCalculator.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/Functor.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/util/Converter.java
    jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/control/gui/JUnitTestSamplerGui.java
    jmeter/trunk/src/junit/test/AfterAnnotatedTest.java
    jmeter/trunk/src/junit/test/BeforeAnnotatedTest.java
    jmeter/trunk/src/junit/test/DummyAnnotatedTest.java
    jmeter/trunk/src/protocol/ftp/org/apache/jmeter/protocol/ftp/sampler/FTPSampler.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/DNSCacheManager.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorThread.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/KerberosManager.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/gui/RecordController.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/AuthPanel.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/CookiePanel.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/gui/HeaderPanel.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/AnchorModifier.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/modifier/RegExUserParameters.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/BaseParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/CssParserCacheLoader.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JTidyHTMLParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/URLCollection.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Daemon.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/FormCharSetFinder.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/SamplerCreatorFactory.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerBeanInfo.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/ConversionUtils.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPConstantsInterface.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPResultConverter.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/StandardGenerator.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java
    jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/control/gui/BeanShellSamplerGui.java
    jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ClientPool.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSamplerGui.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/render/ObjectMessageRenderer.java
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LDAPArguments.java
    jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java
    jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/config/MongoSourceElement.java
    jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/config/MongoSourceElementBeanInfo.java
    jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/control/gui/TCPSamplerGui.java
    jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/BinaryTCPClientImpl.java
    jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
    jmeter/trunk/test/src/org/apache/jmeter/control/TestTransactionController.java
    jmeter/trunk/test/src/org/apache/jmeter/functions/SumFunctionTest.java
    jmeter/trunk/test/src/org/apache/jmeter/functions/TestDigestFunction.java
    jmeter/trunk/test/src/org/apache/jmeter/functions/TestFileToString.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestHTTPMirrorThread.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestBaseParser.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHTMLParser.java
    jmeter/trunk/test/src/org/apache/jmeter/report/dashboard/ApdexPerTransactionTest.java
    jmeter/trunk/test/src/org/apache/jmeter/resources/PackageTest.java
    jmeter/trunk/test/src/org/apache/jmeter/resources/TestPropertiesFiles.java
    jmeter/trunk/test/src/org/apache/jmeter/test/ResourceLocator.java
    jmeter/trunk/test/src/org/apache/jmeter/testelement/TestNumberProperty.java
    jmeter/trunk/test/src/org/apache/jmeter/util/XPathUtilTest.java
    jmeter/trunk/test/src/org/apache/jmeter/visualizers/TestSampleCompareTo.java
    jmeter/trunk/xdocs/changes.xml

Comment 1 Antonio Gomes Rodrigues 2017-12-06 22:27:17 UTC

New Revision: 1817322

URL: http://svn.apache.org/viewvc?rev=1817322&view=rev
Log:
PR345,61867 - Updated to latest checkstyle (v8.5), add bug number

Modified:
    jmeter/trunk/xdocs/changes.xml

Comment 2 The ASF infrastructure team 2022-09-24 20:38:11 UTC

This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4633