Bug 62030 - Column shifting in HSSF and SXSSF scenario
Summary: Column shifting in HSSF and SXSSF scenario
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-22 13:58 UTC by Dragan Jovanović
Modified: 2018-01-24 20:27 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dragan Jovanović 2018-01-22 13:58:30 UTC
There was an issue about column shifting : https://bz.apache.org/bugzilla/show_bug.cgi?id=61474 . It is implemented for XSSF scenario (implementation covers column shifting, and all issues which arise with it, not only adjusting of formulae, as title suggests; it resides at https://github.com/apache/poi/pull/81), but HSSF scenario is covered only partially. So, all features from https://github.com/apache/poi/pull/81 should be implemented for hssf too.
There are classes BaseTestColumnShifting and TestHSSFColumnShifting which cover this issue. All dummy test methods should be removed from TestHSSFColumnShifting, so that original methods from BaseTestColumnShifting class can show what does not work.
There is also class TestXSSFColumnShifting which works well, and which tests xssf solution from issue 61474.
Comment 1 Dragan Jovanović 2018-01-24 09:46:37 UTC
The same goes for SXSSF variation, so please take a look at SXSSFRow class, and implement methods shiftCellsRight() and shiftCellsLeft(). Then open TestSXSSFRow and remove testCellShiftingRight() and testCellShiftingLeft() override methods, so that original versions of those methods can test SXSSFRow.
Comment 2 Greg Woolsey 2018-01-24 20:27:08 UTC
Is it even fully supportable in SXSSF?  Given that only a portion of rows are still available at any given time, I'm not sure it's reasonable to ask to shift full columns in that context.  Perhaps that use case should trigger an explicit runtime exception.