Bug 62038 - slide.draw should be failsaife(r)
Summary: slide.draw should be failsaife(r)
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 3.17-FINAL
Hardware: PC All
: P2 major (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-23 17:59 UTC by Wolfgang Fahl
Modified: 2019-01-06 13:14 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Fahl 2018-01-23 17:59:32 UTC
When trying to export some 900 powerpoint slides I get some 18 exceptions in the process producing image files of 0 bytes size.

Here are some example exception reasons:

java.lang.IllegalArgumentException: Currently only SolidPaint is supported!
	at org.apache.poi.xslf.usermodel.XSLFTextRun.setFontColor(XSLFTextRun.java:153)

java.lang.NullPointerException
	at org.apache.poi.xslf.usermodel.XSLFHyperlink.getAddress(XSLFHyperlink.java:57)

java.lang.NullPointerException
	at org.apache.poi.xslf.usermodel.XSLFTextRun.copy(XSLFTextRun.java:602)

java.lang.NullPointerException
	at java.util.TreeMap.getEntry(TreeMap.java:347)
	at java.util.TreeMap.get(TreeMap.java:278)
	at org.apache.poi.openxml4j.opc.PackageRelationshipCollection.getRelationshipByID(PackageRelationshipCollection.java:286)
	at org.apache.poi.openxml4j.opc.PackagePart.getRelationship(PackagePart.java:392)
	at org.apache.poi.xslf.usermodel.XSLFSheet.importBlip(XSLFSheet.java:596)

There is only a bit of variety and you might consider this a different bugs. From my point of view the main issue is to make sure that suche detail errors in part of the rendering process should not necessarily make the whole rendering fail. It would be good to have an option for this (or is there already such a thing?.
Comment 1 Wolfgang Fahl 2018-01-24 11:03:48 UTC
The first workaround I found is to change copy in XSLFTextRun.java like this:


        double srcFontSize = 12.0;
        try {
            srcFontSize=r.getFontSize();
        } catch (NullPointerException npe) {
            npe.printStackTrace();
        }

getFontSize is the culprit but in my eclipse debuggin environment it does not show with it's details in the stacktrace.
Comment 2 Wolfgang Fahl 2018-01-24 13:51:59 UTC
The Nullpointer Exception seems to be nasty since it doesn't seem to have a stacktrace.

I am currently looking at https://stackoverflow.com/questions/2411487/nullpointerexception-in-java-with-no-stacktrace

and http://jawspeak.com/2010/05/26/hotspot-caused-exceptions-to-lose-their-stack-traces-in-production-and-the-fix/ to find out why
Comment 3 Wolfgang Fahl 2018-01-24 14:02:43 UTC
Its much simpler then I though.
Assigning getFontSize() Double result to a double calls for trouble if the
Double may be null.

I suggest to not only change the Declaration to
Double srcFontSize

but also make the getFontSize function itself more robust.
I am going to prepare a pull request for this.
Comment 4 Wolfgang Fahl 2018-01-24 14:04:20 UTC
Here is a manuall git diff for a start:
+++ b/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTextRun.java
@@ -41,6 +41,7 @@ import org.openxmlformats.schemas.drawingml.x2006.main.CTRegularTextRun;
 import org.openxmlformats.schemas.drawingml.x2006.main.CTSchemeColor;
 import org.openxmlformats.schemas.drawingml.x2006.main.CTShapeStyle;
 import org.openxmlformats.schemas.drawingml.x2006.main.CTSolidColorFillProperties;
+import org.openxmlformats.schemas.drawingml.x2006.main.CTTextBodyProperties;
 import org.openxmlformats.schemas.drawingml.x2006.main.CTTextCharacterProperties;
 import org.openxmlformats.schemas.drawingml.x2006.main.CTTextField;
 import org.openxmlformats.schemas.drawingml.x2006.main.CTTextFont;
@@ -206,9 +207,18 @@ public class XSLFTextRun implements TextRun {
     @Override
     public Double getFontSize(){
         double scale = 1;
-        CTTextNormalAutofit afit = getParentParagraph().getParentShape().getTextBodyPr().getNormAutofit();
-        if(afit != null) {
-            scale = (double)afit.getFontScale() / 100000;
+        XSLFTextParagraph pp = getParentParagraph();
+        if (pp!=null) {
+            XSLFTextShape ps = pp.getParentShape();
+            if (ps!=null) {
+                CTTextBodyProperties tbp = ps.getTextBodyPr();
+                if (tbp!=null) {
+                    CTTextNormalAutofit afit = tbp.getNormAutofit();
+                    if(afit != null) {
+                        scale = (double)afit.getFontScale() / 100000;
+                    }
+                }
+            }
         }
 
         CharacterPropertyFetcher<Double> fetcher = new CharacterPropertyFetcher<Double>(_p.getIndentLevel()){
@@ -222,7 +232,8 @@ public class XSLFTextRun implements TextRun {
             }
         };
         fetchCharacterProperty(fetcher);
-        return fetcher.getValue() == null ? null : fetcher.getValue()*scale;
+        Double result=fetcher.getValue() == null ? null : fetcher.getValue()*scale;
+        return result;
     }
 
     /**
@@ -589,7 +600,7 @@ public class XSLFTextRun implements TextRun {
             setFontColor(srcFontColor);
         }
 
-        double srcFontSize = r.getFontSize();
+        Double srcFontSize=r.getFontSize();
         if(srcFontSize  != getFontSize()){
             setFontSize(srcFontSize);
         }
Comment 5 Wolfgang Fahl 2018-01-24 15:22:30 UTC
see pull request https://github.com/apache/poi/pull/92 for a fix