Bug 62408 - (New feature) Make configurable the number of retries in case of upstream failures
Summary: (New feature) Make configurable the number of retries in case of upstream fai...
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Connectors
Classification: Unclassified
Component: mod_jk (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
: 48564 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-05-24 15:43 UTC by Frederik
Modified: 2018-09-03 14:04 UTC (History)
1 user (show)


Attachments
Patch implementing the desired funcionality (5.07 KB, patch)
2018-05-24 15:43 UTC, Frederik 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederik 2018-05-24 15:43:41 UTC 
Created attachment 35947 [details]
Patch implementing the desired funcionality

This is a patch we're using in production from some years now.

This adds a new configuration parameter to load balancer workers, named lb_retries.

There can be set the number of retries when a request to upstream fails. Right now the behaviour we observe is that in case of failure the LB retries to all workers at least once. When all backends are busy this adds even more load in our experience.

Please consider merging, and ask for any additional info needed.


Thanks
Comment 1 Mark Thomas 2018-08-23 18:31:01 UTC 
*** Bug 48564 has been marked as a duplicate of this bug. ***
Comment 2 Mark Thomas 2018-08-24 07:56:49 UTC 
Thanks for the patch. I'm testing it now and expect to commit it later today.

A couple of minor points so far:
- The retries options includes the original request so this new option should
  have the same behaviour
- The patch doesn't include any documentation

I've already fixed these locally so this is a suggestion of things to consider for future submissions rather than a request for an updated patch.
Comment 3 Mark Thomas 2018-08-24 12:12:55 UTC 
Thanks again for the patch. Applied (with minor changes) to 1.2.x for 1.2.44 onwards.
Comment 4 Frederik 2018-09-03 14:04:14 UTC 
(Sorry for the late reply, just back from vacations)

Thanks for the corrections, I'll keep your suggestions in mind for future submitions.

Thanks again,
F