Bug 62482 - ForEach Controller Input/Output variables are not required
Summary: ForEach Controller Input/Output variables are not required
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 4.0
Hardware: All All
: P2 normal (vote)
Target Milestone: JMETER_5.0
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2018-06-21 13:36 UTC by orimarko
Modified: 2018-09-05 14:25 UTC (History)
2 users (show)



Attachments
Mark as not required fields in foreach controller (1.27 KB, patch)
2018-07-12 05:57 UTC, orimarko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description orimarko 2018-06-21 13:36:33 UTC
ForEach Controller documentation mark Output variable as required although it's not.

When left empty, ForEach Controller is still looping without setting any extra variable.

ForEach Controller documentation mark Input variable prefix as required although it's not.

When left empty, ForEach Controller is still looping through variables _1, _2,...
Comment 1 Felix Schumacher 2018-07-11 20:03:09 UTC
Do you want to submit a patch to adapt the documentation?
Comment 2 orimarko 2018-07-12 04:30:13 UTC
Can the documentation change? In order to support two more options of execution?
Comment 3 Felix Schumacher 2018-07-12 05:12:33 UTC
Yes.

I think we have two options here. First is to change the code to match documentation, but that might lead to breaking test plans. The second one is to document the behaviour and thus make it clear, that it is supported.

I don't like breaking old test plans without need and the 'new' behaviour does no harm, so let's change the documentation.
Comment 4 orimarko 2018-07-12 05:57:12 UTC
Created attachment 36025 [details]
Mark as not required fields in foreach controller
Comment 5 Felix Schumacher 2018-07-14 14:23:41 UTC
Thanks for your contribution.

I have added a short explanation on the defaults that get used when no values are given.

Date: Sat Jul 14 14:21:36 2018
New Revision: 1835906

URL: http://svn.apache.org/viewvc?rev=1835906&view=rev
Log:
Sync documentation to the implementation of the ForEachController. 

Based on contribution by orimarko (orimarko at gmail.com)
Bugzilla Id: 62482

Modified:
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml