Bug 62534 - [signjar] providerClass and providerArg missing
Summary: [signjar] providerClass and providerArg missing
Status: RESOLVED FIXED
Alias: None
Product: Ant
Classification: Unclassified
Component: Core tasks (show other bugs)
Version: 1.10.1
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 1.10.6
Assignee: Ant Notifications List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-12 14:47 UTC by arni.schulze
Modified: 2018-09-28 16:36 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arni.schulze 2018-07-12 14:47:15 UTC
The JDK's jarsigner has the parameters "providerClass" and "providerArg", but Ant's signjar task does not. (These parameters are necessary for signing JARs using GlobalSign certificates which are stored on SafeNet-USB-Tokens.)
Comment 1 Stefan Bodewig 2018-07-12 15:03:57 UTC
I guess they are also needed in verifyjar.

It shouldn't be too difficult to add new attributes.

Maybe we should provide support for nested <arg>s so peopke can use whatever flag they need and don't have to wait for us to provide the implementation and a new release?
Comment 2 Gintas Grigelionis 2018-07-12 21:17:00 UTC
<arg> lacks validation. See e.g. comments to https://github.com/apache/ant/pull/64
Comment 3 Stefan Bodewig 2018-07-13 04:04:11 UTC
Sure, I'm not suggesting to add <arg> instead of specific attributes but rather as a workaround until we add such specific attributes.
Comment 4 Jaikiran Pai 2018-07-13 09:14:53 UTC
>> Maybe we should provide support for nested <arg>s so peopke can use whatever flag they need and don't have to wait for us to provide the implementation and a new release?

For a task like this one, where we wrap a command/tool which has too many permutations/combinations, plus no real specification to follow, I think it's better to support a generic <arg>s element for it.

As for validation of these specified args, in context of this and similar (keytool based) tasks, I am not too sure we doing that validation, by exposing specific attribute names to the task, adds much value. What I mean is, ultimately we end up doing almost the same set of validations that keytool would have done. Plus, recent bug/enhancement reports show that keytool has too many permutations of arguments that behave differently in context of what the command is, adding to the complexity of such validations.
Comment 5 Stefan Bodewig 2018-09-28 16:30:58 UTC
Addes for Ant 1.9.14 and 1.10.6.