Bug 62549 - httpd-2.4.34: 8 * Redundant condition
Summary: httpd-2.4.34: 8 * Redundant condition
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.5-HEAD
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-17 10:46 UTC by David Binderman
Modified: 2018-08-13 12:55 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2018-07-17 10:46:30 UTC 
[httpd-2.4.34/modules/cache/cache_util.c:713]: (style) Redundant condition: warn_head!=NULL. 'A || (!A && B)' is equivalent to 'A || B'
[httpd-2.4.34/modules/cache/cache_util.c:732]: (style) Redundant condition: warn_head!=NULL. 'A || (!A && B)' is equivalent to 'A || B'
[httpd-2.4.34/modules/cache/cache_util.c:789]: (style) Redundant condition: warn_head!=NULL. 'A || (!A && B)' is equivalent to 'A || B'
[httpd-2.4.34/modules/cache/mod_cache.c:1904]: (style) Redundant condition: warn_head!=NULL. 'A || (!A && B)' is equivalent to 'A || B'
[httpd-2.4.34/modules/cache/mod_cache.c:912]: (style) Redundant condition: warn_head!=NULL. 'A || (!A && B)' is equivalent to 'A || B'
[httpd-2.4.34/modules/filters/mod_ext_filter.c:164]: (style) Redundant condition: **args=='"'. '**args!='"' || (**args=='"' && escaping)' is equivalent to '**args!='"' || escaping'
[httpd-2.4.34/server/mpm/netware/mpm_netware.c:1209]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR' is always true.
[httpd-2.4.34/server/util.c:853]: (style) Redundant condition: If 'EXPR == '\\'', the comparison 'EXPR' is always true.
Comment 1 Yann Ylavic 2018-08-13 12:55:01 UTC 
Thanks, addressed in r1837941.