Bug 62822 - Default Summary Report min/max values are inaccurate
Summary: Default Summary Report min/max values are inaccurate
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 3.3
Hardware: PC All
: P2 trivial (vote)
Target Milestone: JMETER_5.1
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-12 20:08 UTC by AJ Johnson
Modified: 2018-10-18 21:27 UTC (History)
0 users



Attachments
A screenshot of the Summary Report with inaccurate display values (15.92 KB, image/png)
2018-10-12 20:08 UTC, AJ Johnson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description AJ Johnson 2018-10-12 20:08:30 UTC
Created attachment 36195 [details]
A screenshot of the Summary Report with inaccurate display values

In the Summary Report, when no samples have been processed (i.e., after clearing the report) the displayed minimum and maximum values are inaccurate. The minimum displays as the largest positive long integer value (9223372036854775807) while the maximum displays as the lowest negative long integer value(-9223372036854775808).

This is due to the Calculator class' initial values for the minimum and maximum instance variables:

    private long maximum = Long.MIN_VALUE;

    private long minimum = Long.MAX_VALUE;

In reality, when no samples have been processed, all values related to the Calculator's dataset should be undefined. Other values are initialized as 0, and therefore display as 0 instead of some seemingly random value in the UI. The min/max should likely also *display* as 0 when no samples have been processed.
Comment 1 Felix Schumacher 2018-10-13 13:44:03 UTC
Added a pull request on Github under https://github.com/apache/jmeter/pull/407

Initial values for min and max will be displayed as "#N/A".
Comment 2 Felix Schumacher 2018-10-16 17:40:35 UTC
Will be in the next version, which is probably 5.1.

Could you test the next nightly, if it works for you? 

Date: Tue Oct 16 17:33:44 2018
New Revision: 1844031

URL: http://svn.apache.org/viewvc?rev=1844031&view=rev
Log:
Render uninitialized min and max values in Summary Report as `#N/A`

In the Summary Report min and max values are initialized with
`Long#MAX_VALUE` and `Long#MIN_VALUE` to work easily with them.

Those initial values are looking weird in the rendered view.
Hide them by replacing the extrema by the text `#N/A`.

Closes #407 on github
Bugzilla Id: 62822

Date: Tue Oct 16 17:36:39 2018
New Revision: 1844032

URL: http://svn.apache.org/viewvc?rev=1844032&view=rev
Log:
Add missing License header

Followup to r1844031

Render uninitialized min and max values in Summary Report as `#N/A`

In the Summary Report min and max values are initialized with
`Long#MAX_VALUE` and `Long#MIN_VALUE` to work easily with them.

Those initial values are looking weird in the rendered view.
Hide them by replacing the extrema by the text `#N/A`.

Closes #407 on github
Bugzilla Id: 62822
Comment 3 Felix Schumacher 2018-10-16 18:51:10 UTC
Date: Tue Oct 16 18:50:09 2018
New Revision: 1844043

URL: http://svn.apache.org/viewvc?rev=1844043&view=rev
Log:
Unused import

Followup to r1844031

Render uninitialized min and max values in Summary Report as `#N/A`

In the Summary Report min and max values are initialized with
`Long#MAX_VALUE` and `Long#MIN_VALUE` to work easily with them.

Those initial values are looking weird in the rendered view.
Hide them by replacing the extrema by the text `#N/A`.

Relates to #407 on github
Bugzilla Id: 62822


Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java
Comment 4 AJ Johnson 2018-10-18 21:27:30 UTC
(In reply to Felix Schumacher from comment #2)
> Will be in the next version, which is probably 5.1.
> 
> Could you test the next nightly, if it works for you? 
> 
> Date: Tue Oct 16 17:33:44 2018
> New Revision: 1844031
> 
> URL: http://svn.apache.org/viewvc?rev=1844031&view=rev
> Log:
> Render uninitialized min and max values in Summary Report as `#N/A`
> 
> In the Summary Report min and max values are initialized with
> `Long#MAX_VALUE` and `Long#MIN_VALUE` to work easily with them.
> 
> Those initial values are looking weird in the rendered view.
> Hide them by replacing the extrema by the text `#N/A`.
> 
> Closes #407 on github
> Bugzilla Id: 62822
> 
> Date: Tue Oct 16 17:36:39 2018
> New Revision: 1844032
> 
> URL: http://svn.apache.org/viewvc?rev=1844032&view=rev
> Log:
> Add missing License header
> 
> Followup to r1844031
> 
> Render uninitialized min and max values in Summary Report as `#N/A`
> 
> In the Summary Report min and max values are initialized with
> `Long#MAX_VALUE` and `Long#MIN_VALUE` to work easily with them.
> 
> Those initial values are looking weird in the rendered view.
> Hide them by replacing the extrema by the text `#N/A`.
> 
> Closes #407 on github
> Bugzilla Id: 62822

Tested it today on latest build, and it looks solid to me.