Bug 62929 - [PATCH] Missing blip fill of picture causes NPE
Summary: [PATCH] Missing blip fill of picture causes NPE
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 4.0.x-dev
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-20 11:20 UTC by Mate Borcsok
Modified: 2018-11-20 14:21 UTC (History)
0 users


Attachments
test-data/slideshow/missing-blip-fill.pptx (39.78 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2018-11-20 11:20 UTC, Mate Borcsok 		Details
fix NPE in XSLFPictureShape and add test case to TestXSLFBugs (2.84 KB, patch)
2018-11-20 11:22 UTC, Mate Borcsok 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mate Borcsok 2018-11-20 11:20:01 UTC 
Created attachment 36267 [details]
test-data/slideshow/missing-blip-fill.pptx

We found a weird example (attached, added to test-data) which includes a picture but its blipFill is empty. That caused a NullPointerException.
Please check my fix proposal and the test case.
Comment 1 Mate Borcsok 2018-11-20 11:22:03 UTC 
Created attachment 36268 [details]
fix NPE in XSLFPictureShape and add test case to TestXSLFBugs
Comment 2 PJ Fanning 2018-11-20 14:21:02 UTC 
Merged using https://svn.apache.org/viewvc?view=revision&revision=1847004