Bug 63048 - JMeter does not retrieve link resources of type "shortcut icon" or "icon"
Summary: JMeter does not retrieve link resources of type "shortcut icon" or "icon"
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: HTTP (show other bugs)
Version: 3.3
Hardware: All All
: P2 normal (vote)
Target Milestone: JMETER_5.1
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2018-12-31 12:48 UTC by Flavio Pepino
Modified: 2019-01-15 19:46 UTC (History)
1 user (show)



Attachments
Jmeter file (9.08 KB, application/xml)
2018-12-31 14:16 UTC, Flavio Pepino
Details
home page image (144.22 KB, image/png)
2018-12-31 14:18 UTC, Flavio Pepino
Details
Replay in jmeter (79.40 KB, image/png)
2018-12-31 14:19 UTC, Flavio Pepino
Details
har file (113.51 KB, text/plain)
2019-01-05 00:03 UTC, Flavio Pepino
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Flavio Pepino 2018-12-31 12:48:19 UTC
I've realized the number of requests made in Jmeter were not equal to Firefox.
I don't do requests filtering. The CSS files are retrieved normally. However,
I've found the requests to files  referred  in CSS using background-image are not made during the replay in JMeter.
Comment 1 Philippe Mouawad 2018-12-31 13:40:11 UTC
Hello,
Please provide a simple html page that embeds a css and the corresponding css fole where images are not extracted.
Comment 2 Flavio Pepino 2018-12-31 14:16:39 UTC
Created attachment 36352 [details]
Jmeter file

jmx file to replay the issue.
Comment 3 Flavio Pepino 2018-12-31 14:18:16 UTC
Created attachment 36353 [details]
home page image

shows the requests to home page.
Comment 4 Flavio Pepino 2018-12-31 14:19:37 UTC
Created attachment 36354 [details]
Replay in jmeter

shows the replay to request to /
Comment 5 Flavio Pepino 2018-12-31 14:33:24 UTC
Sorry, I DO requests filtering.
So, I trust the request will retrieve all embedded resources if the option in the sampler is marked.
However, the files that referred in css are not requested.
When I visit the home page of Drupal sandbox, https://dm9l7.ply.st, I see 7 requests. THe sandboxes last 24 hours, If it has expired, you have to create another one, CHoose Drupal Core and 8.6.2.
The jmeter jmx is attached in order to replay this isssue and you can see the images too. 
For example, enable developer tools and visit the home page and you will see 7 requests. Replay the same request to / in Jmeter and you will see just 5 requests.
Comment 6 Flavio Pepino 2019-01-01 00:17:38 UTC
"CHoose Drupal Core and 8.6.2."
The site that I referred in previous comments is simplytest.me
Comment 7 Philippe Mouawad 2019-01-04 19:40:10 UTC
Hello Flavio,

Creating a sandbox is not easy for me.

Could you please:

- Do it again
- Using a fresh / clear cache browser instance, call the page and save as HAR
or save HTML + resources as a zip
- Show which requests are not being saved

Are you sure missing requests are triggered by CSS and not javascript executed code ?

Thank you
Comment 8 Flavio Pepino 2019-01-04 23:59:55 UTC
The missing images are referred in css files using background-image .
The missing images are loupe.svg and feed.svg

The procedure to create the sandbox is extremely simple.

Just go to simplytest.me and choose Drupal Core and version 8.6.2 and click launch sandbox button.

I've saved the har file.
Comment 9 Flavio Pepino 2019-01-05 00:03:13 UTC
Created attachment 36366 [details]
har file

Home navegation
Comment 10 Philippe Mouawad 2019-01-14 21:51:39 UTC
(In reply to Flavio Pepino from comment #9)
> Created attachment 36366 [details]
> har file
> 
> Home navegation

Thank you Flavio.

So I analyzed , there are 2 additional URLs:

- https://dmdv0.ply.st/core/misc/favicon.ico 
- https://dmdv0.ply.st/core/misc/icons/505050/loupe.svg


The first one is favicon.ico, we could probably add this one
The second one is because by default we don't download url() in CSS file as their potential downloading depends on display parameters in browser, information that we don't have.
Comment 11 Philippe Mouawad 2019-01-14 22:31:02 UTC
Author: pmouawad
Date: Mon Jan 14 22:30:00 2019
New Revision: 1851300

URL: http://svn.apache.org/viewvc?rev=1851300&view=rev
Log:
Bug 63048 - JMeter does not retrieve link resources of type "shortcut icon" or "icon"

Contributed by UbikLoadPack (https://ubikloadpack.com)
Bugzilla Id: 63048

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JsoupBasedHtmlParser.java
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/LagartoBasedHtmlParser.java
    jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestBug60842HtmlParser.java
    jmeter/trunk/xdocs/changes.xml
Comment 12 Philippe Mouawad 2019-01-14 22:33:13 UTC
Hello Flavio,
favicon.ico is now downloaded.

For the other resources, for now we won't be able to improve much.
Comment 13 Flavio Pepino 2019-01-15 15:28:34 UTC
Sorry for my ignorance about your work. Will we see the correction in Jmeter 5.1?
Comment 14 Philippe Mouawad 2019-01-15 15:30:53 UTC
You can already try nightly build:

- https://ci.apache.org/projects/jmeter/nightlies/

And yes it will be in 5.1
Comment 15 Flavio Pepino 2019-01-15 16:23:49 UTC
Philippe
Thanks for you attention.
I will wait the official release.
Comment 16 Philippe Mouawad 2019-01-15 16:43:30 UTC
(In reply to Flavio Pepino from comment #15)
> Philippe
> Thanks for you attention.
> I will wait the official release.

It would be nice if you could at least make a test with nightly build.

It would be annoying to discover an issue after release.
Thanks
Comment 17 Flavio Pepino 2019-01-15 17:48:10 UTC
I will check out the nightly build.
Comment 18 Flavio Pepino 2019-01-15 19:46:44 UTC
While trying the nightly build I saw the icon's problem is solved.