Bug 63141 - Make sure that translations of script interface preserve "OK -" prefix in response text
Summary: Make sure that translations of script interface preserve "OK -" prefix in res...
Alias: None
Product: Tomcat 9
Classification: Unclassified
Component: Manager (show other bugs)
Version: 9.0.14
Hardware: PC All
: P2 regression (vote)
Target Milestone: -----
Assignee: Tomcat Developers Mailing List
Depends on:
Reported: 2019-02-04 11:45 UTC by Konstantin Kolinko
Modified: 2019-02-04 14:21 UTC (History)
0 users


Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kolinko 2019-02-04 11:45:19 UTC
The Ant tasks that communicate with Manager and Host Manager web applications expect that the first line of a successful response starts with "OK -" literally.

See AbstractCatalinaTask.java

> if (!line.startsWith("OK -")) {

As I am looking at translations (at Russian translation, to be specific), I see that some translations break this convention. E.g. I see that sometime it uses "OK-" instead of "OK -".

Maybe the tool that is used to import translations into Tomcat source can check that the "OK -" prefix is preserved.
Comment 1 Michael Osipov 2019-02-04 12:45:00 UTC
I'd rather see the manager having a proper REST interface with status codes and supplemental JSON responses. I, too, have to parse the messages.
Comment 2 Mark Thomas 2019-02-04 14:21:00 UTC
Fixed all the current strings and added a test case to check them going forwards.