Bug 63159 - Problem with native/Makefile.in introduced with native v1.2.21
Summary: Problem with native/Makefile.in introduced with native v1.2.21
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Native
Classification: Unclassified
Component: Library (show other bugs)
Version: 1.2.21
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-08 13:29 UTC by Bob Huemmer
Modified: 2019-06-18 20:03 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Huemmer 2019-02-08 13:29:09 UTC 
tomcat-native-1.2.21-src was updated to deliver some include files from the source tree; however, the change wasn't made properly and as a result tomcat-native-1.2.21-src fails to install when the configure/build directory resides outside of the tomcat-native-1.2.21-src tree. The following change is required below to correct the issue. (Add $(srcdir)/) Normally one would configure/build in the tomcat-native-1.2.21-src tree itself or a subdirectory within the tree. This seems to work properly; however, if you configure/build/install in directories that reside outside of the tomcat-native-1.2.21-src tree this reveals the problem.

Possible fix that worked for me: tomcat-native-1.2.21/native/Makefile.in

83c83
<       $(INSTALL_DATA) include/*.h $(DESTDIR)$(includedir)
---
>       $(INSTALL_DATA) $(srcdir)/include/*.h $(DESTDIR)$(includedir)


The following error is what I get when the configure/build directory resides outside of the tomcat-native-1.2.21-src tree without the change above:

/usr/local/bin/install -c -m 644        include/*.h /my/playpen/install/include
install: include/*.h: No such file or directory
Comment 1 Mark Thomas 2019-06-18 20:03:25 UTC 
Thanks for the report and the patch. I can reproduce this and confirm that the patch fixes it. Many thanks. The fix will be in 1.2.22 onwards.