Bug 63201 - SearchTreeDialog disappears behind master JFrame
Summary: SearchTreeDialog disappears behind master JFrame
Status: RESOLVED FIXED
Alias: None
Product: JMeter
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.1
Hardware: PC Linux
: P2 minor (vote)
Target Milestone: JMETER_5.1.1
Assignee: JMeter issues mailing list
URL:
Keywords: FixedInTrunk
Depends on:
Blocks:
 
Reported: 2019-02-22 18:25 UTC by Benoit Vatan
Modified: 2019-02-22 19:52 UTC (History)
1 user (show)



Attachments
Add parent to SearchTreeDialog (3.29 KB, patch)
2019-02-22 18:38 UTC, Benoit Vatan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benoit Vatan 2019-02-22 18:25:32 UTC
In JMeter GUI, when searching in the tree using Ctrl+F and the SearchTreeDialog, the dialog disappears behind JMeter JFrame if focus is tranfered to the JFrame for some reason (by clicking in the tree for example).

This is because the SearchTreeDialog has no parent.
Comment 1 Benoit Vatan 2019-02-22 18:38:33 UTC
Created attachment 36454 [details]
Add parent to SearchTreeDialog

Suggested patch for fixing. Tested on Linux with Java 1.8.0_121.
Set a parent on SearchTreeDialog from SearchTreeCommand whose code had to be enhanced to retrieve the master JFrame that is not directly exposed.
Comment 2 Felix Schumacher 2019-02-22 19:52:50 UTC
Thanks for the great description and patch. The fix will be included in the next version of JMeter.

One minor thing, instanceof is true only if the object is not null.

Date: Fri Feb 22 19:49:30 2019
New Revision: 1854171

URL: http://svn.apache.org/viewvc?rev=1854171&view=rev
Log:
SearchTreeDialog disappears behind master JFrame

Contributed by Benoit Vatan (benoit.vatan at gmail.com)
Bugzilla Id: 63201

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeCommand.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/SearchTreeDialog.java
    jmeter/trunk/xdocs/changes.xml